streamich / react-use

React Hooks — 👍
http://streamich.github.io/react-use
The Unlicense
42k stars 3.16k forks source link

Change some dependencies to `peerDependencies` to use them in different applications #2565

Open meluiz opened 4 months ago

meluiz commented 4 months ago

What is the current behavior? I am currently receiving an error when using react-use in React Native applications.

Steps to reproduce it and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have extra dependencies other than react-use. Paste the link to your JSFiddle or CodeSandbox example below:

  1. yarn add react-use
  2. yarn start

What is the expected behavior?

It is expected that some hooks, which rely exclusively on the browser to run, should treat their dependencies as peerDependencies and make it optional to download them for use.

An example I can mention is useCss, which depends on nano-css. Even if I don't use useCss in the React Native application, I receive an error due to the nano-css dependency, where there is a check for a global variable that does not exist in a mobile environment.

A little about versions:

mrtawil commented 4 months ago

+1

pranshuchittora commented 4 months ago

+1