streamich / react-use

React Hooks — 👍

http://streamich.github.io/react-use

The Unlicense

42k stars 3.16k forks source link

useCallback to wrap useHash mount and unmount lifecycles fix#2594 #2595

Closed asasvirtuais closed 2 months ago

asasvirtuais commented 2 months ago

Description

useCallback to wrap useHash mount and unmount lifecycles

useLifecycles(
  useCallback( () => on(window, 'hashchange', onHashChange), []),
  useCallback( () => off(window, 'hashchange', onHashChange), [])
);

Type of change

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as before)

Checklist

[ ] Read the Contributing Guide
[ ] Perform a code self-review
[ ] Comment the code, particularly in hard-to-understand areas
[ ] Add documentation
[ ] Add hook's story at Storybook
[ ] Cover changes with tests
[ ] Ensure the test suite passes (yarn test)
[ ] Provide 100% tests coverage
[ ] Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
[ ] Make sure types are fine (yarn lint:types).

asasvirtuais commented 2 months ago

The rabbit hole is deeper than I imagined it'd be. Seems like useEffect would be the right approach to solve this issue with Next.js, but it would completely change the way this works on React only apps.