S3 session initialization without static creds

streamingfast / dstore

Blob stores abstractions. Supports AWS S3, Google Storage, Azure Blob File Storage, and local FS

https://dfuse.io

Apache License 2.0

11 stars 10 forks source link

S3 session initialization without static creds #3

Closed sosedoff closed 2 years ago

sosedoff commented 2 years ago

Currently the S3 session is initialized via session.NewSession(awsConfig) which expects static credentials by default and does not seem to support standard AWS_* env vars.

I can submit a PR that will use session.NewSession without args and let AWS figure out how to do auth if provided storage url does not contain key/secret pairs. I have it working in a local fork, but wanted to see if you're interested in this kind of a change.

maoueh commented 2 years ago

Yeah we will accept such change, go ahead and I'll review.