search

streamingfast / firehose-ethereum

Ethereum on StreamingFast
Apache License 2.0
78 stars 24 forks source link

/healthz returns "is_ready: true" when shutting down #66

Closed matthewdarwin closed 1 year ago

matthewdarwin commented 1 year ago

When using common-system-shutdown-signal-delay: 30s this gives time for the load-balancer to stop sending traffic to the endpoint before it shuts down. However /healthz URL returns is_ready: true during this time, so there is no way for the load balancer to understand it is in shutdown state, making the flag "useless".

maoueh commented 1 year ago

This seems to be a bug, which app is this?

matthewdarwin commented 1 year ago

substreams tier1. Might apply to firehose or substreams tier2 as well. I didn't check those.

maoueh commented 1 year ago

Definitely a bug, the firehose app has a check to check is shutdown is pending: https://github.com/streamingfast/firehose/blob/develop/app/firehose/app.go#L202-L214

What version/commit are you using exactly, could be a recent regression..

matthewdarwin commented 1 year ago

I'm testing 1.4.7 before we roll it out.

matthewdarwin commented 1 year ago

Closing in favour of: https://github.com/streamingfast/firehose-core/issues/9