search

streamingfast / solana-go

Go library for the Solana Blockchain
Apache License 2.0
121 stars 25 forks source link

fix: remove unavailable dependency + fix assignment #7

Closed ryanswrt closed 3 years ago

ryanswrt commented 3 years ago

When trying to use the "develop" branch via go get I encountered an error about a missing dependency "dfuse-io/dfuse-solana" - this PR removes the dependency and cleans up the mod/sum files to remove other unnecessary dependencies.

The previous PR also contained an issue with assignment; I guess this was not picked up as the package did not compile. It would be good to add CI to catch these in future; happy to add a configuration if it would help, but it seems like rpcpool requires some authentication so am uncertain about what's the best way to get all tests to pass

maoueh commented 3 years ago

@TheAncientGoat Don't hesitate to contribute GitHub Actions for building/testing. Inspiration if required:

https://github.com/dfuse-io/dfuse-eosio/tree/develop/.github/workflows