search

streamingfast / substreams-ethereum

Substreams development kit for Ethereum chains, contains Firehose Block model and helpers as well as utilities for Ethereum ABI encoding/decoding.
Apache License 2.0
22 stars 9 forks source link

Update to `ethabi` 18.0.0 in `substreams-ethereum` #17

Open maoueh opened 1 year ago

maoueh commented 1 year ago

We should update to version 18.0.0 (https://github.com/rust-ethereum/ethabi/blob/master/CHANGELOG.md#1800---2022-11-16) of ethabi, it comes with speed up improvements around the encoder which will speed up eth_call creation as well as some fixes around nested tuples.

maoueh commented 1 year ago

It's important to note that everyone using the ABI generator feature currently needs to add an import ethabi = "17" in their Cargo.toml for code to compile properly.

This means that bumping to 18.0.0 will required when bumping to 0.x.0 (because bumping ethabi is a breaking change) will require to also bump their ethabi version. This will need to be super clear in the upgrade instructions of the release (and of course in the changelog).