search

streamingfast / substreams-rs

9 stars 3 forks source link

Allow "." in the expressions #22

Closed YaroShkvorets closed 5 months ago

YaroShkvorets commented 5 months ago

Antelope chains allow "." in the account names and it's natural to use account names in blockIndex keys. However, when using such account names in the blockFilter, the parser fails. The alternative is to use quotes but it's not obvious and not great DX.

This PR makes parser accept "." in the expressions.

maoueh commented 5 months ago

Does the substreams Go version does accepts it? We will need to align to ensure the semantics is the same. We have a parser fo Go at https://github.com/streamingfast/substreams/tree/develop/sqe.

I'll check quickly.

ArnaudBger commented 5 months ago

Hey @YaroShkvorets, based on our go parser, I have updated our parser rule. Almost all characters should be accepted now (dot included !)

YaroShkvorets commented 5 months ago

Great, thanks.

ArnaudBger commented 5 months ago

It's released on v0.5.18 !

YaroShkvorets commented 5 months ago

Tested, works well.