search

streamingfast / substreams-sink-kv

Substreams KV sink
Apache License 2.0
2 stars 5 forks source link

Add Query (no stream) handler in Wasm Query Service #17

Open jubeless opened 1 year ago

jubeless commented 1 year ago

The current WASM query implementation registers all services as streams

https://github.com/streamingfast/substreams-sink-kv/blob/622a3eb856f9155682a82b400508c3d033448e07/server/wasm/server.go#L32-L42

Irrelevant of the proto specification

https://github.com/streamingfast/substreams-sink-kv/blob/622a3eb856f9155682a82b400508c3d033448e07/server/wasm/testdata/wasmquery/test.proto#L7-L12

There is no point in supporting stream since our current WASM query handler returns a single message. We should either support both or migrate everything to a single message request response.

jubeless commented 1 year ago

Close with commit 9fdb804f97fbf716240a20401a41cc47e045a768