search

streamingltd / MEDIAL-Moodle-Activity

The MEDIAL activity plugin for Moodle
GNU General Public License v3.0
3 stars 8 forks source link

$PAGE->set_url() warning being displayed for version 2018090708 #1

Closed sarahjcotton closed 5 years ago

sarahjcotton commented 6 years ago

The following warning is being shown for the Helix Module with debugging on, for the page /admin/plugins.php as well as many others:

This page did not call $PAGE->set_url(...). Using http://localhost/moodle/admin/plugins.php
line 600 of \lib\pagelib.php: call to debugging()
line 820 of \lib\pagelib.php: call to moodle_page->magic_get_url()
line 16 of \mod\helixmedia\settings.php: call to moodle_page->__get()
line 89 of \lib\classes\plugininfo\mod.php: call to include()
line 47 of \admin\settings\plugins.php: call to core\plugininfo\mod->load_settings()
line 8001 of \lib\adminlib.php: call to require()
line 7886 of \lib\adminlib.php: call to admin_get_root()
line 203 of \admin\plugins.php: call to admin_externalpage_setup()
tim1mw commented 5 years ago

This will be fixed in the next release, see my comments in #5 for more info.

troywilliams commented 5 years ago

Hi,

I am getting the same notice in certain admin pages. Plugins and search.

This page did not call $PAGE->set_url(...). Using https://gumbygold.box/learning_v3.7/admin/plugins.php
line 600 of /lib/pagelib.php: call to debugging()
line 820 of /lib/pagelib.php: call to moodle_page->magic_get_url()
line 64 of /mod/helixmedia/settings.php: call to moodle_page->__get()
line 89 of /lib/classes/plugininfo/mod.php: call to include()
line 47 of /admin/settings/plugins.php: call to core\plugininfo\mod->load_settings()
line 8363 of /lib/adminlib.php: call to require()
line 8250 of /lib/adminlib.php: call to admin_get_root()
line 203 of /admin/plugins.php: call to admin_externalpage_setup()

Using version 2019052102

Cheers

aspark21 commented 4 years ago

@tim1mw when is this next release going to materialise?

It's been 6 months since the last release and this issue having been flagged up...

tim1mw commented 4 years ago

Sorry, this slipped through the net, the fix should be in the next release which will be done once I've finished validating the plugins on Moodle 3.8, currently in progress.