streamlink / streamlink-twitch-gui

A multi platform Twitch.tv browser for Streamlink
https://streamlink.github.io/streamlink-twitch-gui/
MIT License
2.7k stars 204 forks source link

Notifications don't display when stream title is empty #1006

Closed Sneakpeakcss closed 6 months ago

Sneakpeakcss commented 6 months ago

Checklist

Streamlink Twitch GUI version

v2.5.0

Streamlink version

6.5.0

Operating system, environment and configuration details

Windows 10 22H2

Description

A bit of an edge case, but (at least on Windows) notifications don't display if channels title is empty, which happens when it was either manually removed, or as a base state for newly created channels.

Debug log

[2024-05-05T14:17:54.101Z][debug][Application]
Parameters
{
    "_": [],
    "tray": false,
    "hide": false,
    "hidden": false,
    "max": false,
    "maximize": false,
    "maximized": false,
    "min": false,
    "minimize": false,
    "minimized": false,
    "reset-window": false,
    "versioncheck": true,
    "version-check": true,
    "logfile": true,
    "disable-gpu": true,
    "loglevel": "debug",
    "l": "debug",
    "theme": "",
    "launch": "",
    "goto": ""
}

[2024-05-05T14:19:55.313Z][debug][NotificationService]
Showing notification
{
    "provider": "auto",
    "current": "snoretoast",
    "data": {
        "title": "ttttestacc is now live",
        "message": "",
        "icon": "C:\\Users\\user\\AppData\\Local\\Temp\\streamlink-twitch-gui\\cache\\icons\\75305d54-c7cc-40d2-bb9c-92fbe85943c7-profile_image-300x300.png",
        "settings": 1
    }
}

[2024-05-05T14:21:55.609Z][debug][NotificationService]
Showing notification
{
    "provider": "auto",
    "current": "snoretoast",
    "data": {
        "title": "ttttestacc is now live",
        "message": "test title",
        "icon": "C:\\Users\\user\\AppData\\Local\\Temp\\streamlink-twitch-gui\\cache\\icons\\75305d54-c7cc-40d2-bb9c-92fbe85943c7-profile_image-300x300.png",
        "settings": 1
    }
}