Open bastimeyer opened 2 years ago
v2.2.0
No response
.
Since the upgrade of NW.js from 0.64.1 to 0.68.1 in 3d641ad469fbc62023e8ad6566ff3520de708fed (part of the v2.2.0 release), the close event on the main application window doesn't get triggered anymore, and neither seem SIGTERM/SIGINT signal callbacks on the global process instance (not used in the application code). This means that the confirmation dialog won't be shown when trying to close the application while streams are still running. https://github.com/streamlink/streamlink-twitch-gui/blob/2d933e0ba93cbc318b36d54fe5d5ab20767bc27e/src/app/init/instance-initializers/nwjs/instance-initializer.js#L102-L116
close
SIGTERM
SIGINT
I've already had a quick look at the issue, but this needs more debugging with a proper reproduction, so the issue can be reported upstream.
nwjs/nw.js#7981
bastimeyer
commented
2 years ago bastimeyer
commented
2 years ago
Checklist
Streamlink Twitch GUI version
v2.2.0
Streamlink version
No response
Operating system, environment and configuration details
.
Description
Since the upgrade of NW.js from 0.64.1 to 0.68.1 in 3d641ad469fbc62023e8ad6566ff3520de708fed (part of the v2.2.0 release), the
closeevent on the main application window doesn't get triggered anymore, and neither seemSIGTERM/SIGINTsignal callbacks on the global process instance (not used in the application code). This means that the confirmation dialog won't be shown when trying to close the application while streams are still running. https://github.com/streamlink/streamlink-twitch-gui/blob/2d933e0ba93cbc318b36d54fe5d5ab20767bc27e/src/app/init/instance-initializers/nwjs/instance-initializer.js#L102-L116I've already had a quick look at the issue, but this needs more debugging with a proper reproduction, so the issue can be reported upstream.
Debug log
No response