streamlink / streamlink-twitch-gui

A multi platform Twitch.tv browser for Streamlink
https://streamlink.github.io/streamlink-twitch-gui/
MIT License
2.7k stars 204 forks source link

Twitch.tv Commercial break in progress #923

Closed lextra2 closed 2 years ago

lextra2 commented 2 years ago

Checklist

Streamlink Twitch GUI version

2.2.0

Streamlink version

5.0.1-1

Operating system, environment and configuration details

Windows 10 21H1

Description

This ad banner is shown when ads are played. This issue started to happen today. Before, no ads or ad banner was shown. I know it will probably be fixed shortly, but I wanted to mention it anyways.

mpv-shot0001

Debug log

No response

bastimeyer commented 2 years ago

Wrong issue tracker. Streamlink Twitch GUI is just a launcher for Streamlink and is totally unrelated to anything streaming related. This is done by Streamlink. Make sure that you have enabled the "Skip advertisements" checkbox in the Twitch GUI's streaming settings menu, which will set the --twitch-disable-ads CLI parameter when launching streams. This is working fine for pre-roll ads, but apparently there are new issues for mid-roll ads, which needs to be looked into and which is a bit tricky to debug.

Please follow the threads on the Streamlink issue tracker instead and be patient, we are already aware of this. https://github.com/streamlink/streamlink/issues

Instead of closing this one, I'll lock it and keep it open, in order to avoid unnecessary duplicates from people who don't look for closed threads.


bastimeyer commented 2 years ago

I've updated the stickied thread that was already there since a few years. Forgot about that when writing the answer. Closing this one now. Also removed the embedded ads page from the wiki, as it's redundant and unnecessary maintenance work for me.

https://github.com/streamlink/streamlink-twitch-gui/issues/754