streamlink / streamlink-twitch-gui

A multi platform Twitch.tv browser for Streamlink
https://streamlink.github.io/streamlink-twitch-gui/
MIT License
2.66k stars 201 forks source link

Improve display of ad breaks #933

Open bastimeyer opened 1 year ago

bastimeyer commented 1 year ago

Checklist

Description

Opening this as a reminder for myself to improve the display of the stream status during an ad break.

Streamlink prints messages to its log output whenever an ad break occurs, for both pre-roll and mid-roll ads. Streamlink Twitch GUI should show this status in the title of the stream popup or on the watching page whenever ads are being filtered out.

Previously, Streamlink Twitch GUI also delayed the "watching" status until pre-roll ads were finished, but something must have broken recently, and now it's showing the "watching" status even though pre-roll ads are still running.

I should probably also move the ads filtering option a little bit, as it's kinda hidden in the settings menu.

bastimeyer commented 1 year ago

I should probably lock this thread, and reference the stickied meta thread.

Please read this and all the linked threads / docs: https://github.com/streamlink/streamlink-twitch-gui/issues/754