search

streamlink / streamlink

Streamlink is a CLI utility which pipes video streams from various services into a video player
https://streamlink.github.io/
BSD 2-Clause "Simplified" License
10.04k stars 1.11k forks source link

clarify which Streamlink Plugins are supported #1997

Closed back-to closed 6 years ago

back-to commented 6 years ago

Issue

Description

Ref https://github.com/streamlink/streamlink/pull/1972#issuecomment-410530312

Having Plugins in the master branch which won't receive any updated when they break does not make that much sense.

They should all be removed, if they are not supported for any future updates.

Here is a list of some plugins that might not match this

https://github.com/streamlink/streamlink/blob/master/CONTRIBUTING.md#plugin-requests

and could be removed.

This issue is there to decide

Sites which are hosting stolen content as their main source of content

NSFW sites of a pornographic nature (cam sites, porn sites, etc.)

  • bongacams
  • Cam4
  • Camsoda
  • Chaturbate

Sites which are mostly hosting VODs (stolen or legitimate)

of course there are more, but this sentence should probably been changed if the other should stay.

https://raw.githubusercontent.com/streamlink/streamlink/master/docs/plugin_matrix.rst

old plugins that are broken, which most likely won't get fixed in the near future some of them might work with youtube-dl.

useless plugins

beardypig commented 6 years ago

@back-to for SpeedRunsLive, it already hands off to the twitch plugin. What do you that "twitch could be used directly"?

back-to commented 6 years ago

I mean it is just used to redirect a username without doing anything else, wouldn't really call it a needed plugin.

https://www.twitch.tv/USERNAME can be used directly, or if the domain is really wanted the url_re could be just added in twitch.py instead of its own file.

gravyboat commented 6 years ago

Had some time to review these this morning. I'm fine with removing all of these. I also agree about SpeedRunsLive since it's just a Twitch redirect and I've stated before that I don't like sites which "rehost" content since it's pointless and makes Streamlink slower. Regarding the broken plugins, if no one has opened an issue regarding the fact they are broken I don't see any reason to keep them. Since we don't collect any sort of plugin usage statistics it's hard to say what is in use but this list looks good to me.

Edit: On top of that if anyone really wants these specific plugins they can just fork us and keep maintaining it themselves but since we added what we'll support in the plugin requests it makes sense to get rid of these, especially the ones supporting stolen content.

johnthecracker commented 6 years ago

Here is something that doesn't work, plugin does exist:

C:\misc\news>streamlink.exe -ldebug https://www.filmon.com/channel/bbc-news high [cli][debug] OS: Windows 10 [cli][debug] Python: 3.5.2 [cli][debug] Streamlink: 0.14.2+68.gaeba213 [cli][debug] Requests(2.19.1), Socks(1.6.7), Websocket(0.48.0) error: No plugin can handle URL: https://www.filmon.com/channel/bbc-news

Before asking any further question, is filmon plugin staying or getting removed ?

If so, what we will be left with ? Twitch and hlsvariant plugins only in the end ?

beardypig commented 6 years ago

@johnthecracker there are ~190 plugins, removing 17 is hardly just leaving Twitch and hlsvariant (not sure what you mean by that exactly)...

johnthecracker commented 6 years ago

If you remove everything that is not to everybodys' taste I see only hlsvariant plugin remaining. Streamlink is still good to me with hlsvariant plugin only. By the way, what is the future of filmon plugin ? I posted here one example of filmon plugin that fails on one website.

beardypig commented 6 years ago

I don't think filmon is being removed (I don't think it should be, anyway), but someone will have to fix it. It's a question of time and drive to fix these things...

spencerthayer commented 4 years ago

I don't understand why was Arconaitv removed @back-to and @gravyboat. Can you explain?

bastimeyer commented 4 years ago

Sites which are hosting stolen content as their main source of content

  • ArconaiTv
johnthecracker commented 4 years ago

You don't need plugin for site like ArconaiTV

[cli][info] Found matching plugin hls for URL https://videoserver1.org/live/CdTJvwxa0gVbSibBRF_3oA/1580345100/03c66ee368fa1cc51798648a72e7be15.m3u8
[cli][info] Available streams: live (worst, best)
[cli][info] Opening stream: live (hls)
[cli][info] Starting player: mpv.exe
spencerthayer commented 4 years ago

@bastimeyer what is wrong with stolen content? I don't see how that's relevant to the function of Streamlink.

spencerthayer commented 4 years ago

I don't understand @johnthecracker, when I type streamlink https://www.arconaitv.us/stream.php\?id\=192 for example I get error: No plugin can handle URL: https://www.arconaitv.us/stream.php?id=192.

johnthecracker commented 4 years ago

Get playlist .m3u8 in some way, depending on your skills. http sniffer, script.. For this example I used firefox extension "the stream detector". hls plugin works with playlists.

[cli][info] Found matching plugin hls for URL ...
gravyboat commented 4 years ago

@spencerthayer We've taken the stance these sites are not worth supporting and their plugins aren't worth maintaining. It adds too much work for us without providing enough gain and many of the users who requests these types of sites are very demanding and don't contribute in any way. People can always fork or manually side load plugins if they want to.