streamlit / docs

Source code for the Streamlit Python library documentation
https://docs.streamlit.io
Apache License 2.0
110 stars 459 forks source link

Update scrollbars to match theme #1128

Closed sfc-gh-tteixeira closed 1 month ago

sfc-gh-tteixeira commented 1 month ago

📚 Context

Making scrollbars nicer looking.

Note to reviewer: Please navigate to every place on the website where you might find a scrollbar and see if this looks better than before / nothing is broken. Also try different browsers.

🧠 Description of Changes

Before:

before

After:

after

💥 Impact

Size:

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

sfc-gh-dmatthews commented 1 month ago

It looks like the color of the scrollbar for the AI chat in dark mode is off. I'll try to take a look, but feel free to update it if you see it faster @sfc-gh-tteixeira:

image
sfc-gh-tteixeira commented 1 month ago

How do I repro? Kapa doesn't work on this PR or localhost...

sfc-gh-dmatthews commented 1 month ago

@sfc-gh-tteixeira I just opened the dialog locally then made my browser really short to induce the scroll bar. There is another, lateral scroll bar that can show up in code examples, too, but I can only get to that to show up on the live site. (Trying to paste a generated answer into a local dev environment doesn't sufficiently pick up on style.)

image image
sfc-gh-tteixeira commented 1 month ago

Fixed. Although now the dialog gets some ugly extra padding on the right when the scrollbar is present, which I don't like.

But I think this is mergeable.

It's so annoying how scrollbars break designs!