search

streamnative / bookkeeper-achieved

Apache Bookkeeper
https://bookkeeper.apache.org
Apache License 2.0
3 stars 2 forks source link

Make read entry request recyclable #447

Closed codelipenghui closed 1 year ago

codelipenghui commented 1 year ago

Descriptions of the changes in this PR:

Motivation

(Explain: why you're making that change, what is the problem you're trying to solve)

Changes

(Describe: what changes you have made)

Master Issue: #

In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit checks for pull requests. A pull request can only be merged when it passes precommit checks.

Be sure to do all of the following to help us incorporate your contribution quickly and easily:

If this PR is a BookKeeper Proposal (BP):

  • [ ] Make sure the PR title is formatted like: <BP-#>: Description of bookkeeper proposal e.g. BP-1: 64 bits ledger is support
  • [ ] Attach the master issue link in the description of this PR.
  • [ ] Attach the google doc link if the BP is written in Google Doc.

Otherwise:

  • [ ] Make sure the PR title is formatted like: <Issue #>: Description of pull request e.g. Issue 123: Description ...
  • [ ] Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • [ ] Replace <Issue #> in the title with the actual Issue number.
codecov[bot] commented 1 year ago

Codecov Report

Merging #447 (a29880c) into master (bf5a6aa) will increase coverage by 7.92%. The diff coverage is 95.83%.

@@             Coverage Diff              @@
##             master     #447      +/-   ##
============================================
+ Coverage     60.34%   68.27%   +7.92%     
- Complexity     5849     6767     +918     
============================================
  Files           473      473              
  Lines         40910    40977      +67     
  Branches       5232     5240       +8     
============================================
+ Hits          24689    27977    +3288     
+ Misses        14001    10745    -3256     
- Partials       2220     2255      +35
Flag Coverage Δ
bookie 39.80% <91.66%> (+0.03%) :arrow_up:
client 44.13% <95.83%> (?)
remaining 29.40% <0.00%> (+<0.01%) :arrow_up:
replication 41.34% <91.66%> (+0.03%) :arrow_up:
tls 20.97% <91.66%> (+0.04%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pache/bookkeeper/proto/PerChannelBookieClient.java 80.28% <50.00%> (+6.29%) :arrow_up:
...g/apache/bookkeeper/proto/BookieProtoEncoding.java 81.00% <100.00%> (+3.89%) :arrow_up:
...va/org/apache/bookkeeper/proto/BookieProtocol.java 85.80% <100.00%> (+2.23%) :arrow_up:
...rg/apache/bookkeeper/proto/ReadEntryProcessor.java 51.92% <100.00%> (+2.40%) :arrow_up:
...a/org/apache/bookkeeper/proto/ResponseBuilder.java 72.72% <0.00%> (-18.19%) :arrow_down:
...org/apache/bookkeeper/client/BookieInfoReader.java 65.40% <0.00%> (-5.41%) :arrow_down:
...g/apache/bookkeeper/proto/PacketProcessorBase.java 48.51% <0.00%> (-1.99%) :arrow_down:
...apache/bookkeeper/verifier/BookkeeperVerifier.java 86.06% <0.00%> (-1.82%) :arrow_down:
...eeper/bookie/EntryLogManagerForSingleEntryLog.java 83.67% <0.00%> (-1.03%) :arrow_down:
...va/org/apache/bookkeeper/bookie/EntryMemTable.java 84.32% <0.00%> (-0.55%) :arrow_down:
... and 133 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codelipenghui commented 1 year ago

close the PR since it has been merged to the apache/bookkeeper