streamnative / bookkeeper-achieved

Apache Bookkeeper
https://bookkeeper.apache.org
Apache License 2.0
3 stars 2 forks source link

Fix memory leak issue of reading small entries #448

Closed codelipenghui closed 1 year ago

codelipenghui commented 1 year ago

Descriptions of the changes in this PR:

Motivation

(Explain: why you're making that change, what is the problem you're trying to solve)

Changes

(Describe: what changes you have made)

Master Issue: #


In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit checks for pull requests. A pull request can only be merged when it passes precommit checks.


Be sure to do all of the following to help us incorporate your contribution quickly and easily:

If this PR is a BookKeeper Proposal (BP):

  • [ ] Make sure the PR title is formatted like: <BP-#>: Description of bookkeeper proposal e.g. BP-1: 64 bits ledger is support
  • [ ] Attach the master issue link in the description of this PR.
  • [ ] Attach the google doc link if the BP is written in Google Doc.

Otherwise:

  • [ ] Make sure the PR title is formatted like: <Issue #>: Description of pull request e.g. Issue 123: Description ...
  • [ ] Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • [ ] Replace <Issue #> in the title with the actual Issue number.

codecov[bot] commented 1 year ago

Codecov Report

Merging #448 (745b688) into master (73c5a0e) will increase coverage by 18.54%. The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             master     #448       +/-   ##
=============================================
+ Coverage     49.72%   68.27%   +18.54%     
- Complexity     4816     6754     +1938     
=============================================
  Files           473      473               
  Lines         40910    40918        +8     
  Branches       5232     5234        +2     
=============================================
+ Hits          20342    27936     +7594     
+ Misses        18551    10726     -7825     
- Partials       2017     2256      +239     
Flag Coverage Δ
bookie 39.74% <12.50%> (-0.04%) :arrow_down:
client 44.07% <50.00%> (?)
remaining 29.57% <87.50%> (+0.02%) :arrow_up:
replication 41.28% <12.50%> (?)
tls 20.96% <12.50%> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...g/apache/bookkeeper/proto/BookieProtoEncoding.java 80.40% <100.00%> (+3.29%) :arrow_up:
...ache/bookkeeper/replication/ReplicationWorker.java 75.59% <100.00%> (+0.18%) :arrow_up:
...va/org/apache/bookkeeper/bookie/SkipListArena.java 76.19% <0.00%> (-4.77%) :arrow_down:
...keeper/replication/AuditorCheckAllLedgersTask.java 53.74% <0.00%> (-2.73%) :arrow_down:
...pache/bookkeeper/replication/AutoRecoveryMain.java 41.66% <0.00%> (-1.29%) :arrow_down:
...eeper/bookie/EntryLogManagerForSingleEntryLog.java 83.67% <0.00%> (-1.03%) :arrow_down:
...va/org/apache/bookkeeper/versioning/Versioned.java 75.00% <0.00%> (ø)
...g/apache/bookkeeper/bookie/DefaultEntryLogger.java 79.93% <0.00%> (ø)
...okkeeper/meta/ZkLedgerUnderreplicationManager.java 60.85% <0.00%> (+0.51%) :arrow_up:
... and 237 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codelipenghui commented 1 year ago

Move to closed since the PR has been merged to apache/bookkeeper