streamnative / function-mesh

The serverless framework purpose-built for event streaming applications.
https://functionmesh.io/
Apache License 2.0
213 stars 29 forks source link

prevent setting typeClassName to `[B` when runtime could inferring the typeClassName #561

Open freeznet opened 1 year ago

freeznet commented 1 year ago

https://github.com/streamnative/function-mesh/issues/131 added the inferring typeClassName feature to Pulsar Functions Java runtime, but the webhook prevents the user from providing null to typeClassName. We will need to fix it by removing the webhook Defaulter to enable the new feature for Function Mesh users.

jiangpengcheng commented 1 year ago

which version(tag) does the java runtime image introduce this feature?

we may need to keep the webhook for old image

freeznet commented 1 year ago

@jiangpengcheng I do not have the specific image tags containing the fix, but you could check https://github.com/apache/pulsar/pull/18111 and streamnative/pulsar fork