streamnative / function-mesh

The serverless framework purpose-built for event streaming applications.
https://functionmesh.io/
Apache License 2.0
210 stars 27 forks source link

Sync proto #637

Closed jiangpengcheng closed 1 year ago

jiangpengcheng commented 1 year ago

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #636

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Sync with latest Function.proto

Modifications

  1. Add Manual delivery semantics to function, sink, source
  2. Add CompressionType to function, source
  3. add SkipToLatest to function

Verifying this change

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

Documentation

Check the box below.

Need to update docs?

nlu90 commented 1 year ago

Will this proto-change cause breaking behavior? If this is the case, then we need to clearly mark version requirement

jiangpengcheng commented 1 year ago

Will this proto-change cause breaking behavior? If this is the case, then we need to clearly mark version requirement

I tested that this pr has requirements of runner images' version:

  1. Manual delivery semantics: only supports runner image >= 2.11
  2. CompressionType field: only supports runner image >= 3.0.0
  3. SkipToLatest field: only supports runner image >=3.0.0

If users don't set those values, they won't be passed to runner pods, and there will be no error, so we only need to update the doc for those fields and specify the version requirement.

cc @Huanli-Meng