Closed jiangpengcheng closed 1 year ago
Will this proto-change cause breaking behavior? If this is the case, then we need to clearly mark version requirement
Will this proto-change cause breaking behavior? If this is the case, then we need to clearly mark version requirement
I tested that this pr has requirements of runner images' version:
Manual
delivery semantics: only supports runner image >= 2.11CompressionType
field: only supports runner image >= 3.0.0SkipToLatest
field: only supports runner image >=3.0.0If users don't set those values, they won't be passed to runner pods, and there will be no error, so we only need to update the doc for those fields and specify the version requirement.
cc @Huanli-Meng
(If this PR fixes a github issue, please add
Fixes #<xyz>
.)Fixes #636
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>
to link to the master issue.)Master Issue: #
Motivation
Sync with latest Function.proto
Modifications
Manual
delivery semantics to function, sink, sourceCompressionType
to function, sourceSkipToLatest
to functionVerifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
[x]
doc-required
(If you need help on updating docs, create a doc issue)
[ ]
no-need-doc
(Please explain why)
[ ]
doc
(If this PR contains doc changes)