streamnative / function-mesh

The serverless framework purpose-built for event streaming applications.
https://functionmesh.io/
Apache License 2.0
210 stars 27 forks source link

Do not update unmodifiable fields for StatefulSet #639

Closed jiangpengcheng closed 1 year ago

jiangpengcheng commented 1 year ago

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #638

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

StatefulSet.spec only allow to update below fields:

while during version upgrade of FM, Selector field is changed even with same yaml, and other fields maybe changed in further development too, such as:

we need to ensure these changed won't update old existing statefulset

Modifications

Do not update unmodifiable fields for StatefulSet

Verifying this change

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

Documentation

Check the box below.

Need to update docs?