search

streamnative / function-mesh

The serverless framework purpose-built for event streaming applications.
https://functionmesh.io/
Apache License 2.0
211 stars 28 forks source link

Upgrade to autoscaling/v2 #657

Closed freeznet closed 1 year ago

freeznet commented 1 year ago

Since k8s 1.23 autoscaling/v2beta2 is deprecated, it will be great if function-mesh upgrades to autoscaling/v2

MarkusNeuron commented 1 year ago

Hi guys, this is the only thing blocking us from an needed cluster upgrade. This should be very easy to fix. Thanks for your consideration!

MarkusNeuron commented 1 year ago

Hi, just as info: We forked function mesh and did a "stupid" search and replace on "v2beta2" => "v2", rebuild and containerised the code and it works fine for us. So my comment above is still valid 😄 .

freeznet commented 1 year ago

hi @MarkusNeuron, your solution should be okay according to https://kubernetes.io/docs/reference/using-api/deprecation-guide/#horizontalpodautoscaler-v126. Would you mind opening a PR for the fix? thanks.

MarkusNeuron commented 1 year ago

Hi @freeznet, please have a look: https://github.com/streamnative/function-mesh/pull/658