streamnative / function-mesh

The serverless framework purpose-built for event streaming applications.
https://functionmesh.io/
Apache License 2.0
210 stars 27 forks source link

Decide to whether use pulsarctl based on image name #669

Closed jiangpengcheng closed 1 year ago

jiangpengcheng commented 1 year ago

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #629

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Use pulsarctl when runner image name contains pulsar-functions-pulsarctl-(java|go|python)-runner, so users don't need to pass the imageHasPulsarctl manually

Verifying this change

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

Documentation

Check the box below.

Need to update docs?