streamnative / function-mesh

The serverless framework purpose-built for event streaming applications.
https://functionmesh.io/
Apache License 2.0
210 stars 27 forks source link

Use regex to check whether runner image has pulsarctl #682

Closed jiangpengcheng closed 1 year ago

jiangpengcheng commented 1 year ago

Motivation

Some runner images(such as pulsar-functions-sn-java-runner) may has pulsarctl in /pulsar/bin dir, but we are using /usr/local/bin/pulsarctl as the pulsarctl path, so it's better to use pulsarctl directly and add /pulsar/bin to the $PATH

Modifications

Describe the modifications you've done.

Verifying this change

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

Documentation

Check the box below.

Need to update docs?