Closed jiangpengcheng closed 1 year ago
(If this PR fixes a github issue, please add Fixes #<xyz>.)
Fixes #<xyz>
Fixes #
(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)
Master Issue: #<xyz>
Master Issue: #
Even no log topic is specified, it will start a filebeat container, we should avoid that
Only create filebeat container when log topic is set and the logTopicAgent == sidecar
logTopicAgent == sidecar
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
This change added tests and can be verified as follows:
(example:)
Check the box below.
Need to update docs?
[ ] doc-required
doc-required
(If you need help on updating docs, create a doc issue)
[x] no-need-doc
no-need-doc
(Please explain why)
[ ] doc
doc
(If this PR contains doc changes)
(If this PR fixes a github issue, please add
Fixes #<xyz>
.)Fixes #
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>
to link to the master issue.)Master Issue: #
Motivation
Even no log topic is specified, it will start a filebeat container, we should avoid that
Modifications
Only create filebeat container when log topic is set and the
logTopicAgent == sidecar
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
[ ]
doc-required
(If you need help on updating docs, create a doc issue)
[x]
no-need-doc
(Please explain why)
[ ]
doc
(If this PR contains doc changes)