Closed freeznet closed 10 months ago
@freeznet:Thanks for your contribution. For this PR, do we need to update docs? (The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
@freeznet:Thanks for providing doc info!
@jiangpengcheng please help to verify if https://github.com/streamnative/function-mesh/pull/704/commits/5f675736a3105e6792d4b2bdb9ce0dfc3594d099 is needed.
@jiangpengcheng please help to verify if 5f67573 is needed.
It's better to have it
Then we need to add such logic to controllers/sink.go#ApplySinkCleanUpJob
and cotrollers/source.go#ApplySourceCleanUpJob
too
Motivation
Failed to cleanupSubscription on OLM installation.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
[ ]
doc-required
(If you need help on updating docs, create a doc issue)
[x]
no-need-doc
(Please explain why)
[ ]
doc
(If this PR contains doc changes)