Open jiangpengcheng opened 6 months ago
(If this PR fixes a github issue, please add Fixes #<xyz>.)
Fixes #<xyz>
Fixes #
(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)
Master Issue: #<xyz>
Master Issue: #
but with the default vpa updater, we cannot do that, so create this PR to fit for our charging model
Describe the modifications you've done.
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
This change added tests and can be verified as follows:
(example:)
Check the box below.
Need to update docs?
[ ] doc-required
doc-required
(If you need help on updating docs, create a doc issue)
[x] no-need-doc
no-need-doc
(Please explain why)
[ ] doc
doc
(If this PR contains doc changes)
I took a look at this change and it seemed straightforward to me. I don't have a lot of context on this though, @freeznet or @nlu90 would be better to approve it. Also, the unit tests are still failing.
(If this PR fixes a github issue, please add
Fixes #<xyz>
.)Fixes #
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>
to link to the master issue.)Master Issue: #
Motivation
but with the default vpa updater, we cannot do that, so create this PR to fit for our charging model
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
[ ]
doc-required
(If you need help on updating docs, create a doc issue)
[x]
no-need-doc
(Please explain why)
[ ]
doc
(If this PR contains doc changes)