Make `api` as a separate module - Githubissues

streamnative / function-mesh

The serverless framework purpose-built for event streaming applications.

https://functionmesh.io/

Apache License 2.0

213 stars 29 forks source link

Make `api` as a separate module #749

Closed jiangpengcheng closed 6 months ago

jiangpengcheng commented 6 months ago

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #745

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

[ ] doc-required

(If you need help on updating docs, create a doc issue)
[x] no-need-doc

(Please explain why)
[ ] doc

(If this PR contains doc changes)

jiangpengcheng commented 6 months ago

I'm also confused as to why the RELEASE_VERSION of the operator has to get updated with this but the code change itself seems fine. cc @freeznet if you have a different opinion please mark a review here requesting changes.

the RELEASE_VERSION is not mean the "release version" for the function-mesh-operator, but the "release version" of the operator-sdk