While working with FunctionMesh, we observed that the runner image could only be configured by specifying its repository. In our intranet environment, where all Docker images are used privately, it is essential to always define ImagePullSecrets.
This modification was aimed at ensuring that ImagePullSecrets and ImagePullPolicy can also be specified when downloading the modified runnerImage.
Additionally, we aligned this update with the existing functionality by placing the base runner image configuration within the values.yaml file of the Function Controller, maintaining consistency with the current setup.
Modifications
The modification ensures that when the FunctionMesh Controller uses the Kubernetes library to create StatefulSets for Functions, Sinks, and Sources, the ImagePullSecrets and ImagePullPolicy configurations are properly propagated to the associated POD settings.
Verifying this change
[ ] Make sure that the change passes the CI checks.
This change is already covered by existing tests, such as (please describe tests).
To validate this feature, we deployed the FunctionMesh Controller directly on our existing Pulsar cluster and conducted various tests to ensure its functionality.
We verified that the FunctionMesh Controller correctly applies the ImagePullSecret and ImagePullPolicy configurations for the runner and confirmed that there were no issues with other core functionalities. This was validated by building and testing both the Master Branch and branch-0.22.
Documentation
Check the box below.
Need to update docs?
[X] doc-required
I think following README.md file should me modified to provide information about runner image configuration
Motivation
While working with FunctionMesh, we observed that the runner image could only be configured by specifying its repository. In our intranet environment, where all Docker images are used privately, it is essential to always define ImagePullSecrets.
This modification was aimed at ensuring that ImagePullSecrets and ImagePullPolicy can also be specified when downloading the modified runnerImage.
Additionally, we aligned this update with the existing functionality by placing the base runner image configuration within the values.yaml file of the Function Controller, maintaining consistency with the current setup.
Modifications
The modification ensures that when the FunctionMesh Controller uses the Kubernetes library to create StatefulSets for Functions, Sinks, and Sources, the ImagePullSecrets and ImagePullPolicy configurations are properly propagated to the associated POD settings.
Verifying this change
This change is already covered by existing tests, such as (please describe tests).
Documentation
Check the box below.
Need to update docs?
doc-requiredI think following README.md file should me modified to provide information about runner image configuration