Closed lifepuzzlefun closed 10 months ago
@lifepuzzlefun:Thanks for your contribution. For this PR, do we need to update docs? (The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
@lifepuzzlefun:Thanks for providing doc info!
Merging #1996 (4ef255d) into master (26980a3) will decrease coverage by
0.02%
. Report is 1 commits behind head on master. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #1996 +/- ##
============================================
- Coverage 17.05% 17.04% -0.02%
Complexity 728 728
============================================
Files 191 191
Lines 14235 14248 +13
Branches 1332 1336 +4
============================================
Hits 2428 2428
- Misses 11631 11644 +13
Partials 176 176
Files Changed | Coverage Δ | |
---|---|---|
...e/pulsar/handlers/kop/KafkaTopicLookupService.java | 1.92% <0.00%> (-0.04%) |
:arrow_down: |
.../handlers/kop/stats/DataSketchesOpStatsLogger.java | 0.00% <0.00%> (ø) |
|
...eamnative/pulsar/handlers/kop/stats/LocalData.java | 0.00% <0.00%> (ø) |
|
.../handlers/kop/stats/PrometheusMetricsProvider.java | 0.00% <0.00%> (ø) |
|
...pulsar/handlers/kop/stats/ThreadLocalAccessor.java | 0.00% <0.00%> (ø) |
Fixes #1956
Motivation
FastThreadLocal wont cleanup until thread exit. so we can just check if the stats is not recorded a long time if expired just remove from threadlocal
Modifications
add time check logic if long time have no record just remove the stats.
Verifying this change
Documentation
Check the box below.
Need to update docs?
[ ]
doc-required
(If you need help on updating docs, create a doc issue)
[x]
no-need-doc
(Please explain why)
[ ]
doc
(If this PR contains doc changes)