streamnative / kop

Kafka-on-Pulsar - A protocol handler that brings native Kafka protocol to Apache Pulsar
https://streamnative.io/docs/kop
Apache License 2.0
450 stars 136 forks source link

[fix] Run messageReadStats metrics registerFailedEvent execute on netty threa… #2007

Closed zhouxy0809 closed 12 months ago

zhouxy0809 commented 1 year ago

Fix: follow to https://github.com/streamnative/kop/issues/2006

Motivation

the metric of messageReadStats.registerFailedEvent() not execute in netty thread executor, and not consistent with context code

Modifications

execute messageReadStats.registerFailedEvent() in netty.EventExecutor

Documentation

Check the box below.

Need to update docs?

codecov[bot] commented 1 year ago

Codecov Report

Merging #2007 (1a808ad) into master (014340d) will increase coverage by 0.01%. The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2007      +/-   ##
============================================
+ Coverage     16.95%   16.96%   +0.01%     
- Complexity      728      729       +1     
============================================
  Files           191      191              
  Lines         14307    14309       +2     
  Branches       1339     1339              
============================================
+ Hits           2426     2428       +2     
- Misses        11703    11704       +1     
+ Partials        178      177       -1     
Files Changed Coverage Δ
...tive/pulsar/handlers/kop/storage/PartitionLog.java 8.13% <0.00%> (-0.03%) :arrow_down:

... and 1 file with indirect coverage changes