streamnative / pulsar-resources-operator

Apache License 2.0
34 stars 15 forks source link

v0.5.4 Helm chart release is incorrectly deploying v0.5.3 #234

Closed josephglanville closed 1 month ago

josephglanville commented 2 months ago

See this except from the index:

$ curl -sSL https://charts.streamnative.io/index.yaml | yq '.entries."pulsar-resources-operator"[] | select(.version == "v0.5.4")'
{
  "apiVersion": "v2",
  "appVersion": "v0.5.3",
  "created": "2024-08-12T03:51:31.540993382Z",
  "description": "Pulsar Resources Operator Helm chart for Pulsar Resources Management on Kubernetes",
  "digest": "c03e92253ff6895cf64cf0266929474f97697121cebbfecb625391587fb7c8b7",
  "icon": "https://raw.githubusercontent.com/streamnative/charts/master/static/logo.svg",
  "kubeVersion": ">= 1.18.0-0",
  "name": "pulsar-resources-operator",
  "sources": [
    "https://github.com/streamnative/pulsar-resources-operator"
  ],
  "type": "application",
  "urls": [
    "https://github.com/streamnative/pulsar-resources-operator/releases/download/pulsar-resources-operator-v0.5.4/pulsar-resources-operator-v0.5.4.tgz"
  ],
  "version": "v0.5.4"
}

Note the appVersion is incorrect, this is meaningful because the chart uses the appVersion to determine the image tag.

Furthermore if you download the tarball you will find it includes the v0.5.3 versions of the CRDs which still exhibit the bug that was fixed by #229

This can be worked around by directly applying the CRDs and setting these values on the chart:

image:
  manager:
    tag: v0.5.4

The proper fix is probably just to roll a new release.

freeznet commented 1 month ago

thanks for the issue, please try the latest version instead. i will close this issue and please feel free to reopen it.

josephglanville commented 1 month ago

This appears to be fine in 0.6.0. 👍