streamnative / pulsar-rs

Rust Client library for Apache Pulsar
Other
369 stars 121 forks source link

build: allow to use rustls instead of native-tls #288

Closed FlorentinDUBOIS closed 1 year ago

FlorentinDUBOIS commented 1 year ago
FlorentinDUBOIS commented 1 year ago

Hello @tisonkun :wave:, long time no see ! I made some changes to allow to use rustls instead of native-tls using compiler feature flags. Could you give me your thought of this pull request ?

To give you more context about this pull request, at Clever Cloud, we are doing cross-compiling stuffs and some times build statically binaries and it will helps us, if we could remove the dependency to openssl to do so.

FlorentinDUBOIS commented 1 year ago

By the way, I have updated all dependencies !

FlorentinDUBOIS commented 1 year ago

Hello @tisonkun and @CleverAkanoa, I have deployed this patch in production and it works pretty well.

tisonkun commented 1 year ago

Thank you! I'll review this patch in days.

FlorentinDUBOIS commented 1 year ago

I am glad that you are ok with those modification, I will do the modification above about the hyphen and I will add the compile time error as well. By the way, once this will be merged I will rebase the pull request #267 to integrate those changes.

FlorentinDUBOIS commented 1 year ago

Hey @tisonkun, I did the modification, could you check that everything is ok for you ?

FlorentinDUBOIS commented 1 year ago

As @CleverAkanoa and @tisonkun approve this pull request, I merge it.