Close pulsar reader in both success and failure case - Githubissues

streamnative / pulsar-spark

Spark Connector to read and write with Pulsar

Apache License 2.0

113 stars 50 forks source link

Close pulsar reader in both success and failure case #172

Closed chaoqin-li1123 closed 10 months ago

chaoqin-li1123 commented 10 months ago

Motivation

Currently we don't make sure pulsar reader is closed in all scenarios, only PulsarClientException is handled.

Modifications

Use task completion iterator to make sure pulsar reader is closed.

Verifying this change

[x] Make sure that the change passes the CI checks.

(Please pick either of the following options)

[x] This change is a trivial rework / code cleanup without any test coverage.
[ ] This change is already covered by existing tests, such as:
[ ] This change added tests and can be verified as follows:

Documentation

Check the box below.

Need to update docs?

[ ] doc-required
[x] no-need-doc
[ ] doc