search

streamnative / pulsar-tracing

Tracing instrumentation for Apache Pulsar clients.
Apache License 2.0
20 stars 10 forks source link

Add readme and change Pulsar client dependency scope to provided. #6

Closed codelipenghui closed 4 years ago

codelipenghui commented 4 years ago

Fix #4

Changes

  1. Add readme documentation
  2. Change the Pulsar client dependency scope to provided
  3. Add extractSpanContext() method in the TracingPulsarUtils.java
  4. Update .gitignore
  5. Change group name to io.streamnative
  6. Add TypedMessageBuilderInjectAdapter
codelipenghui commented 4 years ago

@sijie I followed the naming of opentracing contrib

image

We'd better don't contain the interceptor in the module name, because of we may provide decoration client, Kafka also supports interceptor way and decoration client way.

So, I think we can use opentracing-pulsar-client or pulsar-opentracing-client

sijie commented 4 years ago

@codelipenghui sounds good. Lets stick to the current name.