search

streamproc / MediaStreamRecorder

Cross browser audio/video/screen recording. It supports Chrome, Firefox, Opera and Microsoft Edge. It even works on Android browsers. It follows latest MediaRecorder API standards and provides similar APIs.
https://www.webrtc-experiment.com/msr/
MIT License
2.62k stars 563 forks source link

Feature Request: MultiStreamRecorder - removeStream #136

Open wootencl opened 7 years ago

wootencl commented 7 years ago

Would be nice if there was an additional helper method that allowed for the removal of a steam for the MultiStreamRecorder. First idea would be to potentially pass in the MediaStream object as ...removeStream(stream) then based on its id delete it from the arrayOfMediaStreams. Need to look at the source a little longer to see how this would effect the stream capture. If I have some free time in the future I can probably try to put a PR with the implementation if that would be of interest.

kim00kim commented 6 years ago

Hello, any updates on this?

I'm currently developing a video conference-like app that can record the videos of users (max of 4) with MultiStreamRecorder. And when a user leaves the room, his placement from the video will become blank and would be available for other user that will join the meeting. Since there is an existing "addStream" method, it would be nice if there would also be a "removeStream" method.

Also, since there there is no method for saving the video, I added a this.save method from the save method of MediaStreamRecorder.

wootencl commented 6 years ago

Hi @kim00kim, I actually ended up forking and making the modifications for removal. Could probably make a PR to try and get it into the main repo but haven't had the time. Here's my fork with the related logic if that's of interest: https://github.com/wootencl/MediaStreamRecorder