streamproc / MediaStreamRecorder

Cross browser audio/video/screen recording. It supports Chrome, Firefox, Opera and Microsoft Edge. It even works on Android browsers. It follows latest MediaRecorder API standards and provides similar APIs.
https://www.webrtc-experiment.com/msr/
MIT License
2.62k stars 563 forks source link

MediaRecorderWrapper didn't passing the media options to the MediaRecorder constructor #139

Closed larvata closed 4 years ago

larvata commented 7 years ago
const mediaRecorder = new MediaStreamRecorder(stream);
mediaRecorder.bitsPerSecond = 128000;

I want to set the bitrate for the webm audio, but the recording file is always use the default bitrate. It seems the "bitsPerSecond" property is not passed to the MediaRecorder.

var recorderHints = {
    mimeType: self.mimeType
};

...

// starting a recording session; which will initiate "Reading Thread"
// "Reading Thread" are used to prevent main-thread blocking scenarios
try {
    mediaRecorder = new MediaRecorder(mediaStream, recorderHints);
} catch (e) {
    // if someone passed NON_supported mimeType
    // or if Firefox on Android
    mediaRecorder = new MediaRecorder(mediaStream);
}