search

streamshub / flink-sql-examples

Apache License 2.0
1 stars 6 forks source link

Stop generating code into source dir #6

Closed robobario closed 2 months ago

robobario commented 2 months ago

It's popped up in a couple of places that the generated code sometimes has qualified classnames, sometimes not. We can sidestep the differences in generated code by not checking them in.

By default it will be generated into target/generated-sources/avro and be made available at compilation time.

In IDEA you may have to use maven > Generate Sources and Update Folders to generate the code before it will compile the project.

katheris commented 2 months ago

I expected GitHub to be able to spot this wasn't a conflict, otherwise I would have merged this ahead of my other PR, so feel free to merge once you've rebased

robobario commented 2 months ago

github did the right thing for sure, someone modifying a class that you're deleting is a good cause for conflict