streamthoughts / jikkou

The Open source Resource as Code framework for Apache Kafka. Jikkou helps you implement GitOps for Kafka at scale!
https://www.jikkou.io/
Apache License 2.0
202 stars 20 forks source link

ACLs deletion not working on AIVEN #468

Closed bertrandcedric closed 2 months ago

bertrandcedric commented 3 months ago

Describe the bug I got the following erreur when I try to delete an ACL TOPIC in AIVEN KAFKA : NullPointerException: Cannot invoke "io.streamthoughts.jikkou.extension.aiven.api.data.KafkaAclEntry.id()" because the return value of "io.streamthoughts.jikkou.extension.aiven.change.acl.KafkaAclEntryChangeHandler$Delete.getEntry(io.streamthoughts.jikkou.core.models.change.ResourceChange, java.lang.Class)" is null

To Reproduce Steps to reproduce the behavior:

The sample yaml resource to delete the ACL :

---
apiVersion: "kafka.aiven.io/v1beta1"
kind: "KafkaTopicAclEntryList"
items:
  - metadata:
      annotations:
        jikkou.io/delete: true
    spec:
      permission: "READWRITE"
      username: "test"
      topic: "test"

Expected behavior We expect that the ACLs is delete in AIVEN.

Runtime environment

bertrandcedric commented 3 months ago

I test with the 0.35.0-SNAPSHOT and it works. I will wait the next release.

Thanks

fhussonnois commented 2 months ago

Fixed with 0.35.0