search

streem / react-native-select-contact

A cross-platform contact selection library for react-native
MIT License
114 stars 50 forks source link

Load Android Gradle Plugin conditionally #21

Closed SaeedZhiany closed 1 year ago

SaeedZhiany commented 4 years ago

This wraps the Android Gradle plugin dependency in the buildscripts section of android/build.gradle in a conditional:

if (project == rootProject) {
    // ... (dependency here)
}

The Android Gradle plugin is only required when opening the project stand-alone, not when it is included as a dependency. By doing this, the project opens correctly in Android Studio, and it can also be consumed as a native module dependency from an application project without affecting the app project (avoiding unnecessary downloads/conflicts/etc).

for more info, you can refer to this thread and especially this comment.

SaeedZhiany commented 1 year ago

close this PR due to similar changes have been applied in https://github.com/streem/react-native-select-contact/pull/27