streem / react-native-select-contact

A cross-platform contact selection library for react-native
MIT License
114 stars 50 forks source link

[1.6.0][pods] Missing required attribute `summary` #44

Closed Bardiamist closed 3 years ago

Bardiamist commented 3 years ago

Error on pod install:

[!] The `react-native-select-contact` pod failed to validate due to 1 error:
    - ERROR | attributes: Missing required attribute `summary`.
seanadkinson commented 3 years ago

Hi there. Can you try to install 1.5.0 and see if this has the same issue? We just pushed 1.6.0 earlier today, but the changes were minimal.

Bardiamist commented 3 years ago

~Hmm, yes, I reverted to 1.5.0 but still have that problem on pod install. Although it was not there before.~

seanadkinson commented 3 years ago

@Bardiamist I just pushed v1.6.1 with a summary added to package.json, which sounds like it might fix the issue, based on some quick googling. Give it a try?

Bardiamist commented 3 years ago

Update: On 1.5.0 pod install works (I just didn't yarn before pod install previously).

Still error on 1.6.1.

seanadkinson commented 3 years ago

At what point does the error occur? Can you provide console output?

Here is what I get in a sample project:

$ yarn add react-native-select-contact@1.6.1
yarn add v1.22.10
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
warning " > react-dom@17.0.1" has incorrect peer dependency "react@17.0.1".
[4/4] 🔨  Building fresh packages...
success Saved lockfile.
success Saved 1 new dependency.
info Direct dependencies
└─ react-native-select-contact@1.6.1
info All dependencies
└─ react-native-select-contact@1.6.1
seanadkinson commented 3 years ago

Oh, nevermind... i reproduced on pod install, as you mentioned.

seanadkinson commented 3 years ago

Alright, we needed to use description in the package.json. Not really sure why this would've been introduced in 1.6, but I've verified 1.6.2 has this resolved now. I'll close, but reopen if you see anything weird. Thanks!