streetcomplete / StreetComplete

Easy to use OpenStreetMap editor for Android
https://streetcomplete.app
GNU General Public License v3.0
3.88k stars 355 forks source link

quest for steps on handrails #1390

Closed ViolaineDo closed 5 years ago

ViolaineDo commented 5 years ago

This quest type is useful for accessibility purposes and used into algorythm to estimate accessibility of an itinerary for blind/elderly. I know that it was not seen as a priority in issue #503 , but I guess it was waiting for someone to create a dedicated issue on handrails especially (issue 503 was about different quests on staircases, including handrails). Please tell me what do you think about it.. cc @smortex

QUEST PROPOSAL (UPDATE)

General

Affected tag(s) to be modified/added: handrail Question asked: Is there (an) handrail(s) along these steps? Answer help : Select the location of the handrail (left, right, middle).

Use case : 1 I am an elderly, connected, I love to travel, I am still active but have moving issue, I want to know if I can go to this supermarket where there is a few steps, with no concerns.. 2 I am a travel agency, I want to show accessible path to my clients. 3 I am a city planner, I want to make my city more welcoming to people.

Checklist

Checklist for quest suggestions (see guidelines):

Ideas for implementation

Proposed GUI: Use the same method as for sidewalks ("is there a pavement along this street), user choose the side of steps by clicking on an image/minimap and answer yes or no.

rugk commented 5 years ago

Please fill out the "new quest" issue template if requesting a new quest. Otherwise, we cannot accept it here.

ViolaineDo commented 5 years ago

Please fill out the "new quest" issue template if requesting a new quest. Otherwise, we cannot accept it here.

Sorry I wasn't sure if it was needed at first. Updated.

rugk commented 5 years ago

Thanks. As I was the one who opened https://github.com/westnordost/StreetComplete/issues/503 initially, I am obviously biased and in favor of this quest. :wink:

If you re-read https://github.com/westnordost/StreetComplete/issues/503 you'll see that idea was not well considered. However, I personally did not know, that this is an accessibility feature. Maybe you can elaborate on the exact use case a little more. How useful is it to know whether there are handrails? And if so, is it actually useful to know where these are (left/right/middle) or may the information that one is (not) there actually be enough?

Off-topic, but BTW: https://github.com/westnordost/StreetComplete/issues/503 also had the idea of asking for "ramps". If you think this is useful/also a good accessibility feature, feel free to create a new issue. (with filled-out issue template; shame on me that I did not do that in https://github.com/westnordost/StreetComplete/issues/503 properly, maybe it was before the time we had this template.)

rugk commented 5 years ago

Regarding GUI: If we want to map all left/middle/right, we need a multi-selection for these obviously, A step can have both left and right handrails.

ViolaineDo commented 5 years ago

Regarding GUI: If we want to map all left/middle/right, we need a multi-selection for these obviously, A step can have both left and right handrails.

I think the quest on sidewalks is doing that, am I wrong?

rugk commented 5 years ago

Yes, may be. I just wanted to highlight it. (And I personally do not know that out of my head.)

ViolaineDo commented 5 years ago

Indeed not great added value to know where the handrail is, just knowing there is one is great. For ramps : yes an other challenge, on my mind ;) My issue for now with ramps is that they are not qualifying if those are accessible or not (they tell if there is but not if accessible, and it is explicitely explained on the wiki that we should map footway with incline info for that, where incline is quite hard to evaluate easily...) and.. Thanks for raising the topic at this time ;)

ViolaineDo commented 5 years ago

Use case : updated on the description...

westnordost commented 5 years ago

Okay, makes sense. Though, I would limit this quest to specifying whether it has a handrail or not, not where it is.

xuiqzy commented 5 years ago

I would like to implement this as a new quest. As I understood, a simple yes/no quest is enough? I already have working code for that tested locally.

I wanted to use this CC0 logo from Wikipedia because it really emphasizes the handrail and not the steps (it is the ISO use handrail logo). Should I modify it somehow and if yes, what is wished for the final logo? I also don't currently know how and where to integrate the logo in the android project. I see many xml files as logos in app/src/main/res/drawable? Are those SVGs? I'll try to learn about that, but any hints are very much appreciated! :)

westnordost commented 5 years ago

That's cool! Yes, yes/no is good.

Those files are not SVGs, but Android Vector Drawables. The paths within these are actually the same format as SVGs, but everything else is different. In Android Studio, you can import SVGs. But anyway, I already long created an icon for that, please use that. I just comitted and pushed it. It's ic_quest_handrail.xml