streetcomplete / StreetComplete

Easy to use OpenStreetMap editor for Android
https://streetcomplete.app
GNU General Public License v3.0
3.82k stars 348 forks source link

[Bug] Zooming in with position indicator offscreen makes it point the wrong way #1842

Closed Atrate closed 4 years ago

Atrate commented 4 years ago

Zooming in with the position indicator offscreen makes it point towards the upper left corner, no matter of the actual position.

How to Reproduce

  1. Scroll the map so the position indicator can't be seen on-screen
  2. Zoom in

Versions affected

v20.0-beta1 Android 10

westnordost commented 4 years ago

I don't understand what is the problem

matkoniecz commented 4 years ago

Zooming in with the position indicator offscreen makes it point towards the upper left corner, no matter of the actual position.

Are you sure that your location as reported by phone GPS is somewhere else? And not to north-west

I don't understand what is the problem

And I think that I understand it (offscreen locator indicator stuck to a star count), but I am unable to reproduce it. Can you attach a recording of a screen (I can explain how I do this)?

HolgerJeromin commented 4 years ago

@Atrate What if you tap/click on the position indicator?

Atrate commented 4 years ago

Are you sure that your location as reported by phone GPS is somewhere else? And not to north-west

Yep, tested it with various angles

What if you tap/click on the position indicator?

It returns properly

Can you attach a recording of a screen (I can explain how I do this)?

Sure, but gonna do it in a few days so that I don't share my home location (though I could try spoofing location with root)

I don't understand what is the problem

The indicator at the edge of the screen changes position to an incorrect one when zooming in, gets stuck to star count.

This might also be something to do with the animations, I no longer see an animation when zooming in at high zoom levels. For some reason the animation is still there at high (worldwide) zoom levels.

My animation length in Android is set to 0.8x

peternewman commented 4 years ago

FWIW I can't reproduce it either.

Are you sure that your location as reported by phone GPS is somewhere else? And not to north-west

Yep, tested it with various angles

So if you have it zoomed out to the SE and continue zooming in to a point on the map it migrates around the screen as you zoom in? Does it migrate back if you zoom back out.

Atrate commented 4 years ago

Update: the bug only happens in perspective view

Does it migrate back if you zoom back out.

Nope

peternewman commented 4 years ago

Update: the bug only happens in perspective view

You mean tapping the compass once? I still can't reproduce it.

westnordost commented 4 years ago

I was able to reproduce it once when in perspective view and north was down somehow.

westnordost commented 4 years ago

Here are two pictures of the bug

  1. The position indicator actually points at screen position 0,0. It is a bug in tangram-es, I reported it already here: https://github.com/tangrams/tangram-es/issues/2165 Screenshot_1590535484
  2. Zooming out a bit reveals that the user's location is not actually southeast, but roughly north Screenshot_1590535501
kmpoppe commented 4 years ago

I can reproduce the exact same issue in the perspective view (in v 20.0 that is) - in top-down the location pointer points the correct way. Screenshot_20200531-130339 Screenshot_20200531-130331

Mannivu commented 4 years ago

I'm having this issue in SC v20.2 F-Droid version. This happens when switching from top down view to 3D view.

Screen record

matkoniecz commented 4 years ago

Note "blocked" label - it means that it requires fix in some external thing.

In this case it is blocked by https://github.com/tangrams/tangram-es/issues/2165 - you can add thumb up reaction there (though please do not make "+1" or "plz fix" comments) or write a PR changing the behaviour.

Mannivu commented 4 years ago

Note "blocked" label - it means that it requires fix in some external thing.

In this case it is blocked by https://github.com/tangrams/tangram-es/issues/2165 - you can add thumb up reaction there (though please do not make "+1" or "plz fix" comments) or write a PR changing the behaviour.

Oh, I see. Thank you, I'll upvote the other issue.