streetcomplete / StreetComplete

Easy to use OpenStreetMap editor for Android
https://streetcomplete.app
GNU General Public License v3.0
3.88k stars 353 forks source link

Quest: Can you provide a photo of [...]? #2762

Closed NotSoImportant closed 3 years ago

NotSoImportant commented 3 years ago

General

Affected tag(s) to be modified/added:: Key:wikimedia_commons

Question asked: Can you provide a photo of [...]?

Answers:

  1. 🔍 Search on wikimedia common
  2. 📷 Take photo

Checklist

Checklist for quest suggestions (see guidelines):

Ideas for implementation

  1. 🔍 Search

    • provide a text box prefilled with the name of the item + a "search" button
    • call the wikimedia commons API and render results
    • user to select 1 file or 1 category
  2. 📷 Take foto

    • take/select a photo
    • have meta data prefilled
    • optional: enter description
    • upload Two possible implementations:
      1. call the wikimedia commons app intent (if installed)
        • if possible Title prefilled with the type and name of the item
        • auto-providing a category is not possible with the current app, I guess
      2. alternative: implement own simple upload interface
        • Name and categorie are already prefilled (maybe not even shown).
        • I am unsure about how to deal with the "depiction" field
        • User can provide a description
        • For simplicity, one license should be choosen already
        • Cons:
        • Need to deal with another login (maybe there is a way to sign into wikimedia with osm account?)
        • Need to deal with more details of the API

Proposed GUI: 🔍 Search

📷 Take foto image

Login for new users

Element selection: Theoretically any node, but some are more valuable / common. We can start with some and extend over time. I checked usage of wikimedia_commons tag, using overpass in Germany / Middle Europe.

Suggested:

Also seen / rarely used:

Automatically adding categories: For the sake of simplification, categories should be automatically added based on osm tags. This can be driven very deep. As far as I understand the wikimedia community, a category is not required but highly desired. So uploading initially with very broad categories might be ok and can be refined by the community later. Additionally the categories could be combined with e.g. the respective country to be more specific.

Maybe this should be extracted to a mapping file, but maybe even to a whole new project, conceptually like openstreetmap/id-tagging-schema

Examples:

Tag: information=* Wikimedia commons category
Tag:information=board Category:Information_boards
Tag:information=map Category:Photographs_of_maps
Tag:information=guidepost Category:Guide_signs
Tag:tourism=artwork Wikimedia commons category
Tag:tourism=artwork Category:Art_works
Tag:artwork_type=sculpture Category:Sculptures
Tag:artwork_type=statue Category:Statues

Please suggest additions/changes...

matkoniecz commented 3 years ago

That was proposed a bit, though this version is the best one so far and actually solves some problems present in earlier proposals.

Though some of problems discussed there remain.

See #1601 https://github.com/streetcomplete/StreetComplete/issues/1601#issuecomment-544299633

See #1883 https://github.com/streetcomplete/StreetComplete/issues/1883#issuecomment-638806649

See #1515

NotSoImportant commented 3 years ago

Thank you @matkoniecz. Seems I did not do a good search before. I read trough these (and also some linked) proposals and comments now.

Which are the problems you think remain? Hopefully we can find solutions together.

matkoniecz commented 3 years ago

Primary problem is that it turns it from OSM editor into OSM editor and Wikimedia Commons upload app.

The first three points from https://github.com/streetcomplete/StreetComplete/issues/1601#issuecomment-544299633 all apply also here. And requires app author to research and satisfy requirements of another community. Also, copyright issues are trickier with photos - for start see https://commons.wikimedia.org/wiki/Commons:Freedom_of_panorama

Communicating to user that they need two logins, obey rules of two different communities and tricky parts of copyright would be quite hard. Someone crossed Germany-Denmark border and are in Denmark? Now they are not allowed to take photos of tourism=artwork unless it is a very old artwork.

I suspect that it would work better as a separate app (potentially reusing StreetComplete code).

See also https://github.com/commons-app/apps-android-commons/issues/883 ("Nearby notable things from OpenStreetMap" in Wikimedia Commons App) - though on that side they would be in turn unhappy about "and add wikimedia_commons tag to the OSM element"

Seems I did not do a good search before.

Hopefully with even more varied description it is more likely that next person with this idea will be more succesfull.

westnordost commented 3 years ago

I've looked at the Wikimedia commons app for Android and iOS and I'd say that this app already provides all the functionality to add photos to Wikimedia commons. I see no point in replicating this functionality in this app.

Granted, of course, the link to OpenStreetMap is missing, but as you said yourself, this is something that can be done better at home. It also then free from the corset of quest type limitations (filtering the right elements for which it is applicable) and you can - at home with iD or JOSM - also add the tag to things other than historic things and artworks but anything.

westnordost commented 3 years ago

Also, a search through wikimedia commons requires internet connection. No other quest type currently requires internet connection.

I think the workflow to add images to wikimedia common is already good as it is: If I understood the Wikimedia Commons app correctly, there is already a mechanism for Wikimedians to request photos to be taken of a certain object which will then be shown in that app.

NotSoImportant commented 3 years ago

@westnordost you are right with your points. I am finally searching for an easy roundtrip to include images into osm data and have not found it yet.

I have the wikimedia commons app installed and used it to upload new photos, but am not aware of such functionality to request photos / show such requests.

NotSoImportant commented 3 years ago

@matkoniecz Thank you for commenting on the details and providing the link to the wikimedia app idea. Unfortutately it looks inaktive, but I will try to follow up on it.

matkoniecz commented 3 years ago

@NotSoImportant App itself is active, this specific issue is probably of the "if someone cares they will implement it or hire someone to implement it".

On topic of linking Wikimedia Commons and OSM objects - https://wiki.openstreetmap.org/wiki/OSM_%E2%86%94_Wikidata_matcher is very useful for that (by linking WIkidata objects you are indirectly link Wikimedia Commons categories and directly link images in Wikidata entries that are always from Wikimedia Commons)

There is also https://fist.toolforge.org/wdfist/ for adding images to Wikidata entries

(many, many objects can get images this way)