search

streetcomplete / StreetComplete

Easy to use OpenStreetMap editor for Android
https://streetcomplete.app
GNU General Public License v3.0
3.9k stars 357 forks source link

kort.ch linked in the privacy policy is dead #2793

Closed matkoniecz closed 3 years ago

matkoniecz commented 3 years ago

Todo:

How to Reproduce Open privacy policy. Click Kort link. Get

screen08

Versions affected Latest at time of writing ( a51c2a911406edce166bfb621f629ebe91c8f119 ) - https://github.com/streetcomplete/StreetComplete/blob/a51c2a911406edce166bfb621f629ebe91c8f119/app/src/main/res/values/strings.xml#L172

It is probably necessary to change it in the root source, without changing string name and go through all languages to edit them to also remove URL there. Is there a smarter way to do this?

Note that we need to start mentioning also Esri privacy policy but that would be likely done better as an extra string (to not invalidate existing translation and make eventual replacement possible without invalidating privacy policy translations again)

matkoniecz commented 3 years ago

Alternative: link site preserved by internet archive but that likely is a bad idea as it points user to a dead project.

westnordost commented 3 years ago

Yeah, true. Maybe both wheelmap and kort should be removed. Should be easier to do this also in languages one doesn't know as then the whole second part of the sentence is cut off. Would you do that?

Note that we need to start mentioning also Esri privacy policy but that would be likely done better as an extra string (to not invalidate existing translation and make eventual replacement possible without invalidating privacy policy translations again)

This is already implemented. The privacy statement of the VectorTileProvider used is added to the privacy policy programmatically. so, part of #2772

matkoniecz commented 3 years ago

Removing just Kort should be doable without issues, but I think that whole sentence can be removed without losing anything truly important (and that is supposed to be short explanation of the situation)

Would you do that?

Yes

matkoniecz commented 3 years ago

Removal was good, because it seems some were translated as

Everything contributed by StreetComplete is added directly to the OpenStreetmap. There is no intervention by third-party apps. This is also true of wheelmap.org or Kort.

(or maybe it is just automatic translator screwing up?)

Ans I see how original text may be understood in this way.

westnordost commented 3 years ago

Nice, thank you!

matkoniecz commented 3 years ago

So now it is 100% complete.

What remained is to push new English strings to POEditor, though it is not urgent as risk that someone will translate privacy policy right now seems low. I considered doing this but failed to even find script handling this part.

I run translation update from Gradle build script to verify that nothing was missed, fixed also one translation that I missed before.