streetcomplete / StreetComplete

Easy to use OpenStreetMap editor for Android
https://streetcomplete.app
GNU General Public License v3.0
3.92k stars 358 forks source link

New quest: Detail what landuse=orchard produces #368

Closed rugk closed 7 years ago

rugk commented 7 years ago

What is possible is to ask users for the produce of farmland with perennial plants, a.k.a plantations: apples, pears, bananas, rubber, coconuts, cocoa, coffee, grapes etc. […] This also requires a country-specific list of common produce types, like it is done for the sports quest because otherwise there are too many choices.

Sure, also trees are easy to answer. So we would have to let the user between trees and fruits first:

What is grown on this orchard?

  • trees
  • fruits
  • (more menu:) "This is no orchard" and "Something else" (maybe "vineyard" :smiley:)

So according to the selection we would have to allow the user to select a type of tree and… seems there are only trees(?). Or does OSM categorize bushes into the "trees" category too?

The UI could be similar to the one of the street paving.

Edit: We need images for these crops:

rugk commented 7 years ago

BTW, why are the strings in capital letters? Should not they be in lower case in most languages?

rugk commented 7 years ago

Current status: Images found, data complete, OSM list changed again, lists regenerated. I also checked, as good as I could, that we have at least images for all result data.

TODO: Batch-resize.

Also: All translators, please pay attention to the difference between peppers and pipers. See https://github.com/rugk/crops-parser/issues/50 for details.

Reminder for @westnordost: Due to splitting of OSM keys, the YAML files may contain more than 15 elements for some countries. Just so you are aware. You can handle this as you want.

rugk commented 7 years ago

Data changed to use area instead of tonnes. Images resized.

That the per-area-data is used is not necessary for the initial version, the data can be always updated later. (In case you don't feel like looking at that PR.) But the pictures is (the last thing that is still) missing.

Ah, okay. I basically waited for that PR there. It was blocking that thing a bit. So I just picked the source data as the other part of the PR does not affect StreetComplete/this issue, so the data should be okay now. I also generated each pair of the source data, so now you can choose the source. If you really want to have a complete list, you may even manually combine them. As you can see in the last line, in the "area version" the data of "Saint Pierre and Miquelon (PM)` is missing. In the tonnes version, you have some data there.

westnordost commented 7 years ago

device-2017-08-15-214802

westnordost commented 7 years ago

Merged.

rugk commented 7 years ago

Awesome! :tada:

rugk commented 7 years ago

I corrected it in the German translation, but again to emphasize for all translators: REMOVED: CURRENTLY BEING CHANGED

westnordost commented 7 years ago

Huh? What you are saying is wrong. There are the following keys:

produce_bell_peppers produce_pepper produce_chili

westnordost commented 7 years ago

Paprika, Pfeffer, Chilli in German

rugk commented 7 years ago

Oh, you actually switched to bell_pepper without any discussion or wiki adjustion? (except of expressing the idea) Okay, your choice/responsibility…

Also produce_bell_peppers should be singular, so at least produce_bell_pepper.

In any case I'd also like to adjust the image names, as one chooses the wrong one otherwise.

westnordost commented 7 years ago

This is just the key for strings, the exact name of the key does not matter. They reflect how it should be translated.

"What is being cultivated here"?

westnordost commented 7 years ago

Also, I renamed your image names for use in StreetComplete anyway. (i.e. "ananas")

rugk commented 7 years ago

Ah, so it is not the key being put into OSM?

rugk commented 7 years ago

BTW: Also cannot find produce_bell_peppers in PoEditor.