streetcomplete / StreetComplete

Easy to use OpenStreetMap editor for Android
https://streetcomplete.app
GNU General Public License v3.0
3.87k stars 353 forks source link

Provide a way to change hydrant type in quest "Where is this fire hydrant located?" #4083

Closed daPhipz closed 2 years ago

daPhipz commented 2 years ago

Use case

When I went on my mapping tour today, I found an incorrectly mapped fire hydrant - it was mapped as fire_hydrant:type=underground, but it should be pillar. However, there was no way of getting to the hydrant type question from this screen:

Screenshot-half

Proposed Solution

My suggestion would be to add an item to the "More Answers" menu that takes the user to the "What type of fire hydrant is this?" question.

daPhipz commented 2 years ago

BTW - is the bottom left option ("On the sidewalk") also applicable when the fire hydrant is located on a bike lane that is not part of the road? Like in the picture below, the left part is for pedestrians and the right part is for bikes. The German translation in the above uses the word "Bürgersteig", a sidewalk where only pedestrian traffic is allowed. This may be misleading for some people.

Straße-small

mnalis commented 2 years ago

Does it happen often? If not, probably best just to leave a note with a picture...

It could be added probably, but one has to weight that against disadvantages.

I.e. it is unlikely that people will mark "pillar" as "underground" by mistake/misunderstanding. Of course, the case of "fat finger" might always happen, but it is also possible (and probably more likely) that there are in reality multiple pillars (e.g. one underground and little farther one pillar), while only one of them is mapped. Given a user choice to change it, could very easily lead to new user making a mistake, e.g. rebranding the less-visible underground one as pillar.


As for the the second issue (which would be better to open as a separate issue next time), fire_hydrant:position=* in English is also using pedestrian "sidewalk" term. It is likely original proponents didn't envision all possibilities, but just most popular ones. Your options are (beside just ignoring/hiding the quest) basically:

Note that while the second method is more precise, it is not defined in wiki, so is more likely to not be understood by data consumers, which is then obviously much worse then using sidewalk answer. So I personally would thus probably just answer sidewalk.

legofahrrad commented 2 years ago

duplicate of #3871