streetcomplete / StreetComplete

Easy to use OpenStreetMap editor for Android
https://streetcomplete.app
GNU General Public License v3.0
3.9k stars 355 forks source link

Quests for Amenities at Campsites #4198

Closed markongh closed 2 years ago

markongh commented 2 years ago

General

For nodes and ways (areas) with the tag "tourism=camp_site" request information about amenities of that campsite. Affected tag(s) to be modified/added: There are many keys/attributes of camp_sites listed here: https://wiki.openstreetmap.org/wiki/Tag:tourism%3Dcamp_site however, I am requested quests be created for the following attributes with the corresponding questions: https://wiki.openstreetmap.org/wiki/Key:fee Question asked: Does this campsite require a fee? https://wiki.openstreetmap.org/wiki/Key:tents Question asked: Does this campsite allow camping in tents and is the terrain suitable for tents? https://wiki.openstreetmap.org/wiki/Key:caravans Question asked: Does this campsite allow camping in vehicles such as RVs, vans, trailers, etc.? https://wiki.openstreetmap.org/wiki/Key:openfire Question asked: Does this campsite allow open fires? https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dshower Question asked: Does this campsite have shower facilities? https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dtoilets Question asked: Does this campsite have toilet facilities?

Checklist

Checklist for quest suggestions (see guidelines):

Ideas for implementation

Element selection: I am unsure what is meant by "Element selection" but all of these quests would modify key attributes within "tourism=camp_site" items, so quest items should show up on the tourism=camp_site object

Metadata needed: None. These should be pretty consistent for all "tourism=camp_site" items.

Proposed UI: For all questions, a simple prompt with "Yes", "No", or "Can't Say..." If "Can't Say" is selected, suggest leaving a public note with the option to leave a note or hide the quest for the user. This is the same prompt/UI for the quest to determine if there is an air compressor at fuel stations which could be repurposed for these camp_site quests.

matkoniecz commented 2 years ago

Does this campsite require a fee?

are you sure that it passes

Not an overwhelming percentage of quests have the same answer (No spam)

mnalis commented 2 years ago

I also (as a cyclotourist) find two other features of camp sites extremely useful:

(and of course phone / website / contact:*, but those are quite another type of entry, so not suggested here)

mnalis commented 2 years ago

are you sure that it passes Not an overwhelming percentage of quests have the same answer (No spam)

According to quick taginfo check and some calculation:

So tents=* is possibly spammy, but the others look ok. (one might try more advanced overpass queries to check the stats of the rest which are not listed in taginfo - if they haven't used up their overpass quotas)

matkoniecz commented 2 years ago

According to quick taginfo check and some calculation: fee=* tag - 70% yes values but the others look ok.

right now it is heavily biased toward no values, I expect that for remaining ones overwhelming answer is "yes, as usual" and asking for all of them is quite pointless.

I suspect the same for toilets and showers if such tag exists. And tents to be overwhelmingly yes.

power_supply=yes actually seems a valid, disabled by default, quest.

mnalis commented 2 years ago
markongh commented 2 years ago

What about in back country camping areas within National Parks where you may have to pay for a permit, but there are no facilities at the camp site location? I think what Europeans refer to as "wild" camping tends to be more common in the United States as "back country" camp sites.

In Italy I have seen quite a few locations that are caravan/camper vans only with no pitches for tents (i.e. they are brick or paved parking spots intended for campers within facility catering to them). I have seen these as both fee and no fee sites, usually depending on the level of services provided.
I do like your implementation of the "Who may camp here?" question. That single question could cover the caravan= and tents= tags at the same time.

I know there is debate about whether or not "an overwhelming percentage of quests have the same answer," but I also look at it as ensuring completeness of data in order to improve the usefulness of tools that may filter on that data. This data would significantly improve the usefulness of a tool like https://opencampingmap.org/ StreetComplete already asks for data that is over 80% the same answer....for example parking=surface for parking is 82.84%. That doesn't mean the data isn't useful.

markongh commented 2 years ago

I also (as a cyclotourist) find two other features of camp sites extremely useful:

* `drinking_water=*` (2.15% of campsites, with 59% `yes` values)

* `power_supply=*` (2.63% of campsites, with 79% `yes` values - although in my experience it is much less than that cry, maybe 1/3 of them, and that is generous )

(and of course phone / website / contact:*, but those are quite another type of entry, so not suggested here)

Yes, I also considered some of these other features as well, but wanted to keep it to simple yes/no responses for this bunch of quest suggestions. drinking_water= and power_supply= would also be good though.

westnordost commented 2 years ago

What about camp_site=*?

mnalis commented 2 years ago

What about camp_site=*?

It seems to me better to map separate simple tags then this (less popular) combined camp_site, both in ease of use and in usability at all (for example, if the camp has drinking_water+toilets+shower but no power_supply, it falls between camp_site=standard and camp_site=serviced so it needs those additional basic tags anyway; and if data consumer was showing only camp_site it would give wrong picture).

Also camp_site is imprecise due to uses of "or"; e.g. it if says camp_site=deluxe, then it might have a pool, or it might have a tennis courts, or it might have a weight lifting machines, etc. People usually look for specific thing, i.e. I want a pool to refresh, so I'd be quite disappointed if the camp_site=deluxe would have tennis court instead.

Also (specifically to SC) separate tags are better due to:

:atom_symbol: Atomic quests: Per quest, only one thing should need to be answered by the user.

(i.e. for camp_site=* user would have to survey all the features before answering the quest; e.g. find out if there is a laundry, even if they do not care about that particular feature, but want to map if there is drinking water).


Anyway, I plan to go camping on bicycle soon to several camping sites, so unless there are objections I'll try to implement (for starters):

matkoniecz commented 2 years ago

This boolean quests seems like a good idea to me.

"Who may camp here?" may be a bit spammy/hard to answer so I am not sure, but I am also not against it.

westnordost commented 2 years ago

@mnalis: Maybe the reason why that tag exists is because if a campsite lacks certain amenities, it would not even be considered a campsite anymore (in certain languages/regions), i.e. it at least constitutes a different type of campsite.

For example, "just a lawn on which you may camp" (+ maybe a toilet) is known in Germany as a "Biwakplatz" or "Trekkingplatz" (see also https://wiki.openstreetmap.org/wiki/DE:Trekkingpl%C3%A4tze ), noone would call these kind of places "Campingplatz". Since it is named differently, it is (from that point of view) a different "primary feature", i.e. would have a separate entry in the iD editor presets.

vehrmann commented 2 years ago

A thought on power_supply=*: when asked, it should be clear if that means a normal power socket e.g. in a building to charge phones etc. or if it means (usually outdoor) sockets at the actual spot to connect a caravan/RV.

mnalis commented 2 years ago

@westnordost that is interesting, in Croatian we basically have only words kamp (just general camping site, without any details) or autokamp (meaning caravan camping site). For further details, one would have to use whole sentences explaining what amenities it has (or does not have). So I'm unsure how German translation would go, but I hope there is some general word to describe "camping site" without specifying details, which could be used?

Because in OSM tourism=camp_site wiki seems to covers all of them:

A tourism=camp_site may be:

  • A developed area with amenities such as electricity, drinking water, toilets, beaches for swimming, etc.
  • A backcountry area with little to no facilities, often accessible only by offroad vehicle or on foot.

I could probably add the function that analyzes all the basic tags after solving quest (e.g. power_supply=*, toilets=*, shower=* etc.) and auto-generate updated camp_site=* value according to wiki rules; but I'm worried that this could be quite misleading (e.g. unless all of the camp quests are surveyed, it would add wrong value), so I'd rather not implement that. (or perhaps only implement it if all of basic tags are set to either yes or no - i.e. none are undefined).. But then again, such automated edit does not add any value IMHO, but only leads to possible data disagreement later if some of the simple tag change, but summary camp_site=* is not updated)

Alternatively, I could also add backcountry=* quest with yes/no answers, if you think that it would be useful? (update: I've added backcountry as OtherAnswer in PR).

mnalis commented 2 years ago

A thought on power_supply=*: when asked, it should be clear if that means a normal power socket e.g. in a building to charge phones etc. or if it means (usually outdoor) sockets at the actual spot to connect a caravan/RV.

Interesting idea @vehrmann; but do you know how to tag those differences in OSM? In places I've been (EU) both outdoor and indoor plugs have been power_supply=cee_7_3 (Type F/Schuko), so plug type cannot be used to differ them, and there does not seem to be established tag (to my knowledge) to map the difference.

So at the moment I plan to use power_supply=yes (perhaps with wording like Can you charge your phone/laptop here?) to map any camp where customer can recharge phone at least (but if there is accepted tag to map the difference, that could possibly be converted to multiple-answer quest).

mnalis commented 2 years ago

The PR #4213 covers most of this, but it does not implement following proposed/discussed tags:

If further discussion here warrants implementing them (or other tags), feel free to discuss the merits here - they might be implemented later as separate PR.

markongh commented 2 years ago

Alternatively, I could also add backcountry=* quest with yes/no answers, if you think that it would be useful? (update: I've added backcountry as OtherAnswer in PR).

I do think this would be useful as well, but the quest should be clear on the definition of 'backcountry' based on https://wiki.openstreetmap.org/wiki/Key:backcountry.

markongh commented 2 years ago

A thought on power_supply=*: when asked, it should be clear if that means a normal power socket e.g. in a building to charge phones etc. or if it means (usually outdoor) sockets at the actual spot to connect a caravan/RV.

Interesting idea @vehrmann; but do you know how to tag those differences in OSM? In places I've been (EU) both outdoor and indoor plugs have been power_supply=cee_7_3 (Type F/Schuko), so plug type cannot be used to differ them, and there does not seem to be established tag (to my knowledge) to map the difference.

So at the moment I plan to use power_supply=yes (perhaps with wording like Can you charge your phone/laptop here?) to map any camp where customer can recharge phone at least (but if there is accepted tag to map the difference, that could possibly be converted to multiple-answer quest).

A thought on this: I have often seen power hookups for caravans/camping vans/RVs referred to as "shore power." This is stolen terminology from power hookups available for boats/ships when they are in port at a dock. I do not have a caravan or RV so I don't typically speak the lingo, but perhaps this terminology can help distinguish between power outlets for small devices/appliances and caravans/RVs.

Carnildo commented 2 years ago

In regards to fees, I checked the data at http://www.uscampgrounds.info/index.html for the western United States. About 10% of the campgrounds listed are "free or under $12"; spot-checking those suggests that about one in five of those is 1) free and 2) an actual campground, not dispersed camping. 98% "no"/2% "yes" seems spammy to me, and that's in the area where I'd expect to find the highest concentration of free campgrounds.

mnalis commented 2 years ago

I do think this would be useful as well, but the quest should be clear on the definition of 'backcountry' based on https://wiki.openstreetmap.org/wiki/Key:backcountry.

@markongh It's currently shown as "Backcountry camping (no facilities)" in PR https://github.com/streetcomplete/StreetComplete/pull/4213

If you think it should be further improved, feel free to suggest better text at https://github.com/streetcomplete/StreetComplete/pull/4213/files#diff-5e01f7d37a66e4ca03deefc205d8e7008661cdd0284a05aaba1858e6b7bf9103R852

westnordost commented 2 years ago

Just tagging the author of the open camping map as an important data consumer: @giggls

giggls commented 2 years ago

OK, I will add a few thoughts regarding this feature.

https://opencampingmap.org has a bug view itself! While some of the bugs shown there are beyond the scope of StreetComplete (e.g. site should be mapped as a polygon rather than a single node) most of them are not.

Here is what i consider the most important missing tags:

  1. campsite name campsite does not have a name

  2. campsite category (see legend on website) Here are my supported categories:

    • ordinary tourist campsite (camping/caravaning) for tents and caravans/RV Tagging: tourism=camp_site, tents=yes, caravans=yes
    • caravan site caravans/RV often only glorified parking lots Tagging: tourism=camp_site, tents=no, caravans=yes or tourism=caravan_site
    • tents only campsite (very rare without backcountry tag) Tagging: tourism=camp_site, tents=yes, caravans=no
    • backcountry very basic campsites Tagging: tourism=camp_site, tents=, caravans=,backcountry=yes (caravans=yes would be very rare but possible)
    • group only campsites Tagging: group_only=yes or scout=yes as a special case
    • nudist campsite Tagging: nudist=yes or nudist=obligatory or nudist=customary or nudist=designated (I support them all because a customer should not choose such a site by default)
    • private campsite Tagging: Like all of the above but with access=private or access=members

    SQL code for category creation is here: https://github.com/giggls/osmpoidb/blob/master/gen_poi_campsites.sql

  3. contact information Some kind of contact information (centact:*, website or phone) should be available.

  4. campsite features The most important features arguably are:

    • toilets=yes
    • shower=yes
    • drinking-water=yes
    • power_supply=yes
    • openfire=yes (on backcountry campsites)

    For most of these features it is better to map them as individual objects and it would be best to not show them as missing from the site if this is already the case, because mapping individual nodes is always better than adding tags to the campsite polygon. I know this is technically complex and I don't know if it would be a viable option to use my json-file for this.

mnalis commented 2 years ago
Many of those are implemented in StreetComplete (click to expand) > 1. **campsite name** > campsite does not have a name OK, we check for name already: https://github.com/streetcomplete/StreetComplete/blob/6d6807896aa85907eb1fa2dd012e473ca26192ef/app/src/main/java/de/westnordost/streetcomplete/quests/place_name/AddPlaceName.kt#L72 > > 2. **campsite category** (see legend on website) > Here are my supported categories: > > * **ordinary tourist campsite** (camping/caravaning) for tents and caravans/RV > Tagging: tourism=camp_site, tents=yes, caravans=yes > * **caravan site** caravans/RV often only glorified parking lots > Tagging: tourism=camp_site, tents=no, caravans=yes or tourism=caravan_site > * **tents only campsite** (very rare without backcountry tag) > Tagging: tourism=camp_site, tents=yes, caravans=no > * **backcountry very basic campsites** > Tagging: tourism=camp_site, tents=_, caravans=_,backcountry=yes > (caravans=yes would be very rare but possible) We allow for those 4 types above: https://github.com/streetcomplete/StreetComplete/blob/6d6807896aa85907eb1fa2dd012e473ca26192ef/app/src/main/java/de/westnordost/streetcomplete/quests/camping/CampType.kt#L3-L9 > 4. **campsite features** > The most important features arguably are: > > * shower=yes > * drinking-water=yes > * power_supply=yes those 3 quests are implemented, I found them as most interesting too! https://github.com/streetcomplete/StreetComplete/tree/v46.0-beta1/app/src/main/java/de/westnordost/streetcomplete/quests/camping

I'll comment on non-implemented stuff in several comments, to hopefully make it more digestible. :smile:

mnalis commented 2 years ago
  1. campsite category (see legend on website)
    • nudist campsite Tagging: nudist=yes or nudist=obligatory or nudist=customary or nudist=designated (I support them all because a customer should not choose such a site by default)

(key is actually named nudism=*). I guess it is quite useful if one is looking for exactly such place; but I don't recall seeing it signed on any camp (as opposed to, say, beaches, where I have).

And even if I'd seen naked people inside it seems I'd have a terrible time trying to decide between yes / obligatory / customary / permissive / designated.

Overpass says that about 447 (0.35%) of campsites are nudism=no%3B%0A%2F%2F%20print%20results%0Aout%20body%3B%0A%3E%3B%0Aout%20skel%20qt%3B&C=84.40594;112.85156;1) and about other 754 (0.59%) have some positive value%3B%0A%2F%2F%20print%20results%0Aout%20body%3B%0A%3E%3B%0Aout%20skel%20qt%3B&C=84.40594;112.85156;1).

Also, maybe not a good match for SC Quest due to confusion about many non-no values (at least in parts of EU I've visited); perhaps an SC Overlay for nudism might be better option if there is enough interested parties, as there are several tags to which it applies ?

mnalis commented 2 years ago
  1. campsite category (see legend on website)
    • private campsite Tagging: Like all of the above but with access=private or access=members

I could add OtherAnswer This is private camp which adds access=private, but I seem to recall from some other issue that that was not particularly welcome (as many other quests could have that as an OtherAnswer). Or maybe I misremember? Would you like such OtherAnswer for camp sites @westnordost?

Overpass says there are some 1130 (0.88%) access=private%3B%0A%2F%2F%20print%20results%0Aout%20body%3B%0A%3E%3B%0Aout%20skel%20qt%3B&C=84.40594;112.85156;1) camp sites.

(access=members would probably need more information like "members of what?" etc, which makes it impractical for SC and would not provide much difference to access=private for regular customers - you'd have to know you have a permission beforehand to access in either case)

mnalis commented 2 years ago
  1. campsite category (see legend on website)

While scout=yes does not seem to have wiki, group_only=yes seems to indicate there might be other restrictions (like church groups only probably would be restricted to groups of believers or church members or something?). It might also require pre-booking or reserving in advance? Or does it accept any random group of people that comes by, but refuses any individual persons (e.g. technically my girlfriend and myself count as group, so we would be allowed, while I by myself would be refused?)

I myself don't recall ever encountering such a camp which allowed only groups of campers (but there were separate problem of course - where we as 5-person group wouldn't be allowed in while a single camper might, due to amount of free space remaining).

So I'm not sure if this would be a good match for SC quest. Overpass%3B%0A%2F%2F%20print%20results%0Aout%20body%3B%0A%3E%3B%0Aout%20skel%20qt%3B&C=84.40594;112.14844;1) says about 1567 (1.22%) of camp sites are marked with group_only=yes.

mnalis commented 2 years ago
  1. contact information Some kind of contact information (centact:*, website or phone) should be available.

I agree those are extremely important for campsites, and to my experience practically always available. I've formerly been adding them usually via OsmAnd (or more recently EveryDoor). StreetComplete ExpertEdition does allow entering phone and website contact information too. It is "probably" :smile: too spammy for general use on amenities as implemented there, but perhaps it might be acceptable for camp sites?

mnalis commented 2 years ago
  1. campsite features
    • openfire=yes (on backcountry campsites)

That one at least should be easy to add as a simple yes/no quest with easy selection on ways,nodes with tourism=camp_site and backcountry=yes.

Overpass says there is about 2565 (1.99%) openfire=yes%3B%0A%2F%2F%20print%20results%0Aout%20body%3B%0A%3E%3B%0Aout%20skel%20qt%3B&C=86.778;100.19531;1) camp sites, of those 1738 are also backcountry=yes

I don't have much experience with backcountry camping or openfire signage to say if it is likely to easily signed / visible / understandable to random SC user.

mnalis commented 2 years ago
  1. campsite features
    • toilets=yes

Not asked currently by StreetComplete, as possibly spammy (basically all non-backcountry camps I've seen have had toilets, even if only chemical ones; see https://github.com/streetcomplete/StreetComplete/issues/4198#issuecomment-1179793163. But that might be just my EU-standard privilege, I admit).

Overpass shows about 761 (0.59%) no-toilets campsites worldwide, with 345 (0.27%) of which are not marked backcountry=yes. However, when looking at only 11449 backcountry=yes campsites (instead at full 129k campsites), it is 3.01% of backcountry campsites which have been marked as having no toilet.

0.59% might sound a little statistically spammy (or not), but that is quite important feature so mapping it would be very useful. Especially as one does not really encounter many camps in a typical day, so it would probably never feel annoyingly spammy. Or at least ask only on backcountry campsites (where 3.01% is much more significant). What do others think?

I would be open to doing PR for camp toilets quest if it would be found acceptable.

matkoniecz commented 2 years ago

nudism

So that is about 6% positive and other 6% negative matches mapped, so it seems not to be spammy (contrary to my experience).

That is because people are far, far more likely to map positive values. Still, 6% positive seems really high?

754 mapped with nudism%3B%0A%2F%2F%20print%20results%0Aout%20body%3B%0A%3E%3B%0Aout%20skel%20qt%3B&C=84.40594;112.85156;1&R)

307 mapped with nudism!=no%3B%0A%2F%2F%20print%20results%0Aout%20body%3B%0A%3E%3B%0Aout%20skel%20qt%3B&C=84.40594;112.85156;1&R)

128 742 in total

So it is rather 0.2% with positive value, and 0.34% with negative, with positive value used far more often if actually applying.

matkoniecz commented 2 years ago

I would be open to doing PR for camp toilets quest if it would be found acceptable.

Maybe asking for backcountry ones without toilet being mapped nearby would be a good idea?

That seems non-spammy, but I don't have much experience with backcountry camping or openfire signage to say if it is likely to easily signed / visible / understandable to random SC user.

And I turn have not seen ANY campsite without fireplace, so my feedback is limited to claim that it would be spammy in Poland. I guess that in more dry areas like Spain it is more likely?

giggls commented 2 years ago

(key is actually named nudism=*). I guess it is quite useful if one is looking for exactly such place; but I don't recall seeing it signed on any camp (as opposed to, say, beaches, where I have).

Rationale about making this a category in OpenCampingMap was that people do not want to stumble upon such a site by mistake when looking for a place to stay.

giggls commented 2 years ago

I would be open to doing PR for camp toilets quest if it would be found acceptable.

Maybe asking for backcountry ones without toilet being mapped nearby would be a good idea?

That seems non-spammy, but I don't have much experience with backcountry camping or openfire signage to say if it is likely to easily signed / visible / understandable to random SC user.

And I turn have not seen ANY campsite without fireplace, so my feedback is limited to claim that it would be spammy in Poland. I guess that in more dry areas like Spain it is more likely?

Most of the "EifeL" campsites do not have a fireplace. https://opencampingmap.org/#10/50.4531/6.4984/0/0/40

giggls commented 2 years ago

I myself don't recall ever encountering such a camp which allowed only groups of campers (but there were separate problem of course - where we as 5-person group wouldn't be allowed in while a single camper might, due to amount of free space remaining).

These are very common in Germany and are usually owned by municipalities. You are often required to stay for at least a week or so and there is a minimum daily fee which makes them basically group-only. Most common use are youth summer camps. I really feel that they should be tagged accordingly because I often stumbled upon them often when looking for a place to sty on a cycling trip.

matkoniecz commented 2 years ago

Rationale about making this a category in OpenCampingMap was that people do not want to stumble upon such a site by mistake when looking for a place to stay.

It DEFINITELY makes sense to show it in OpenCampingMap. But it would make a poor SC quest.

mnalis commented 2 years ago

That is because people are far, far more likely to map positive values. Still, 6% positive seems really high?

Ooops, sorry everyone, it seems that I don't know how to count in overpass when polygons are involved! :cry: Thanks to @matkoniecz for spotting it; I've now gone over them and corrected my Overpass counts above.

mnalis commented 2 years ago

Maybe asking for backcountry ones [...]

That part looks reasonable (and easy to do) to me

[...] without toilet being mapped nearby would be a good idea?

for that however, I'd likely need some help (that is, if I were to do the quest). I currently have no idea how to check if something is nearby current element and exclude quest based on that.

Would [AddTactilePavingCrosswalk.kt](https://github.com/streetcomplete/StreetComplete/blob/master/app/src/main/java/de/westnordost/streetcomplete/quests/tactile_paving/AddTactilePavingCrosswalk.kt) be an good example for that?
westnordost commented 2 years ago

I think it is generally fine to ask for toilets for any campsite. There is already a "has toilet" quest, maybe just add campsites.

I am also thinking whether having those other campsite quests disabled is really necessary. Campsites are usually semi-public grounds, i.e. you do not really need to go "inside" anywhere to walk (through) there.

matkoniecz commented 2 years ago

Shop/restaurants/etc also are semi-public.

mnalis commented 2 years ago

I am also thinking whether having those other campsite quests disabled is really necessary. Campsites are usually semi-public grounds, i.e. you do not really need to go "inside" anywhere to walk (through) there.

I've done PR https://github.com/streetcomplete/StreetComplete/pull/4331 if that is found acceptable. (if not, just reject/close it). I can see it going both ways, although I'd love them to be available by default.