streetcomplete / StreetComplete

Easy to use OpenStreetMap editor for Android
https://streetcomplete.app
GNU General Public License v3.0
3.9k stars 357 forks source link

Quest suggestion: "Is this location open at public holidays?" #4262

Closed dreirund closed 2 years ago

dreirund commented 2 years ago

General

Rationale:

Many places with opening hours (like shops) miss information how public holidays are handled.

Checklist

Checklist for quest suggestions (see guidelines):

Ideas for implementation

Element selection:

Metadata needed:

Proposed UI:

cyclingcat commented 2 years ago
  • Easily answerable by any pedestrian from the outside but a survey is necessary

Is this requirement for a new quest really fulfilled? I have solved many 100 opening hours quests so far (and tagged many opening hours via JOSM and OsmAnd), mostly in Germany, and have noticed that at least in my country the information if the values for "Sunday" includes "public holidays" or not is indicated very rarely. As useful as this information would be for data consumers, I fear that this quest wouldn't be answerable reliably without a lot of additional research (including asking the shop/restaurant operator or even checking on-site on public holidays).

The cycling cat

Helium314 commented 2 years ago

It's not clear to me why this should be a separate quest. Opening hours on public holidays can be added as part of the normal opening hours quest, and I would assume users are aready adding this information (if it is signed).

matkoniecz commented 2 years ago

Strictly speaking in OH quest you cannot answer that something is closed on public holidays.

Helium314 commented 2 years ago

After adding at least some opening hours, you can add off days, and as part of this you can select public holidays... or do you mean something else?

dreirund commented 2 years ago

It's not clear to me why this should be a separate quest. Opening hours on public holidays can be added as part of the normal opening hours quest, and I would assume users are aready adding this information (if it is signed).

Many supermarkets have only specified opening hours like Monday to Friday, Saturday, Sunday closed. Supermarkets and almost all other shops in Germany are closed on public holidays (most of them by law). But that information is mostly not added.

That was the use case for the quest, to add that mostly overseen bit of information.

Since in the mind of people, it is clear that they are closed on public holidays, even if it is a Wednesday where it normally has open.

No general shop in Germany writes on it's sign that it has closed on public holidays, although it has. Public holidays are interpreted like Sundays here.

mnalis commented 2 years ago

IMO assumptions heavily varies by country / region. In Croatia, that assumption varies / depends a lot.

</rant>


But I also think this quest is not needed, because:

matkoniecz commented 2 years ago

opening hours quest already allows specifying Public Holidays both as working (with separate or shared opening hours) or as a off-day

Can you specify PHs as an off day? I think that you cannot do this in SC.

But otherwise I sadly agree :(

I would really like more quests, but like most of my own ideas: it is not viable :(

mnalis commented 2 years ago

Can you specify PHs as an off day? I think that you cannot do this in SC.

Yes you can (Both for off days, and as a working day, you can select Mo-Su and PH in StreetComplete)

BalooUriza commented 2 years ago

Would be interesting if this could appear only near public holidays when this is likely to be signed.

On Mon, Aug 1, 2022 at 3:20 PM dreirund @.***> wrote:

General

  • Affected tag(s) to be modified/added: opening_hours https://wiki.openstreetmap.org/wiki/Key:opening_hours
  • Question asked: Is this location open at public holidays?
    • Possible answers:
      • "No": If the place is closed on public holidays, even if it would have open if the day would not be a public holiday,
      • "Unaffected": If public holiday does not change the opening of a place,
      • "Especially": If the place is open whenever there is a public holiday,
      • "Other answers…": Maybe similar as we have for the general Opening hours quest?: "Differs by type of holiday…", "Open 24/7", "No regular opening hours", "No opening hours sign", "It does not exist…", "Can't say…"

Rationale:

Many places with opening hours (like shops) miss information how public holidays are handled. Checklist

Checklist for quest suggestions (see guidelines https://github.com/streetcomplete/StreetComplete/blob/master/QUEST_GUIDELINES.md ):

  • 🚧 To be added tag is established and has a useful purpose
  • [?] 🤔 Any answer the user can give must have an equivalent tagging (Quest should not reappear to other users when solved by one)
    • Would add "PH"-subtag to "opening_hours".
  • 🐿️ Easily answerable by any pedestrian from the outside but a survey is necessary
  • [?] 💤 Not an overwhelming percentage of quests have the same answer (No spam)
    • The "street surface quality" also appears on almost every road I have in my surroundings, so if that quest is allowed, than this should be, too.
  • 🕓 Applies to a reasonable number of map data (Worth the effort)

Ideas for implementation Element selection:

  • If opening_hours https://wiki.openstreetmap.org/wiki/Key:opening_hours is present but it says nothing about public holidays (PH not present therein), the quest is asked.
  • Unclear to me: Can an explicit PH specification be made in opening hours that basically says "public holiday does not influence opening hours"? -- since we must set PH to indicate that public holidays have taken into account.

Metadata needed: Proposed UI:

— Reply to this email directly, view it on GitHub https://github.com/streetcomplete/StreetComplete/issues/4262, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWDFBSE3LYT27LEG3CFVTLVXAWR3ANCNFSM55IYLTEA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

mcliquid commented 2 years ago

The information would not be consistent. In Germany this is regulated on a country-specific basis. Example from Baden-Württemberg: Every store is allowed to open on three Sundays or holidays of its choice. These can be chosen again every year. In Berlin, there are eight days. That means that this Quest would have to ask again at least once a year whether the opening hours (holiday days) are correct.

From my point of view, the added value for OSM does not meet the effort for the user.