Add overlay to add fire hydrants

[riQQ]

General

Affected tag(s) to be modified/added: emergency=fire_hydrant Add fire hydrant and show existing fire hydrants in overlay to avoid duplication.

Checklist

Checklist for quest suggestions (see guidelines):

• [x] 🚧 To be added tag is established and has a useful purpose
• [x] 🤔 Any answer the user can give must have an equivalent tagging (Quest should not reappear to other users when solved by one) -> doesn't apply to this kind of overlay
• [x] 🐿️ Easily answerable by any pedestrian from the outside but a survey is necessary -> aerial imagery is too bad in most cases and in some countries, e.g. Germany, there are signs that hint at the position of underground fire hydrants
• [x] 💤 Not an overwhelming percentage of quests have the same answer (No spam) -> doesn't apply to this kind of overlay
• [x] 🕓 Applies to a reasonable number of map data (Worth the effort)

Overlay guidelines

• [ ] 🕸️ Contextual only: Overlays should only be used to display data that only makes sense in relation to neighbouring data, e.g. data in a network (such as cycleways, speed limits, ...) or data that depends (to a degree) how surrounding data is tagged (such as road smoothness, lit status, ...). -> not exactly sure if this criterion is fulfilled. At least adding new fire hydrants requires the context of showing already existing fire hydrants in order to not duplicate data.
• [x] 🔎 One aspect: Similar to the atomic quests guideline, only one aspect should be displayed and be editable to the user.
• [x] ⭐ Not a quest: Usually eligible data should either be recorded and displayed in an overlay or as a quest.

Ideas for implementation

Element selection: Existing hydrants: nodes with emergency=fire_hydrant

Metadata needed: Same as for quests about hydrants?

Proposed UI: Show existing hydrants as overlay icons. Bonus: different icons for different types of hydrants.

[westnordost]

not exactly sure if this criterion is fulfilled. At least adding new fire hydrants requires the context of showing already existing fire hydrants in order to not duplicate data.

Not sure man. You could basically say this for every kind of POI. Is it not possible to add this data with every door?

[riQQ]

Sure, other editors can be used for this. Every Door is missing a focused mode as of now (Zverik/every_door#406) but it looks like it's planned to be added in the future. MapComplete would also be an option, although it's a web app and not a native app.

So I guess this is a matter of how you want to scope the overlay feature. I can totally understand if this is deemed to be out of scope for StreetComplete.

[westnordost]

Every door is a native app.

[riQQ]

I never said that it wasn't. I only said that MapComplete is not a native app.

[westnordost]

Oh, ok

[westnordost]

Anyway, I think I'll reject that for now. Overlays should really serve one really narrow purpose and I am not sure whether StreetComplete's overlays should be broadened to serve such thematic editing (fire hydrants, trees, bicycle parkings, ....) too. This is a use case that Every Door may be ideal to fill later on.

[peternewman]

Not sure man. You could basically say this for every kind of POI.

I was going to suggest something similar but a bit broader, probably called street furniture or similar, including things like postboxes, benches, fire hydrants, defibrilators etc. Basically the shop overlay, but you pick an item of street furniture instead of a shop type (so where the presets have it, you could even pick a BT phone box for example). Like shops, suitable icons will already exist.

Anyway, I think I'll reject that for now. Overlays should really serve one really narrow purpose and I am not sure whether StreetComplete's overlays should be broadened to serve such thematic editing (fire hydrants, trees, bicycle parkings, ....) too.

Do you feel something a bit broader like street furniture is still unsuitable @westnordost ?

This is a use case that Every Door may be ideal to fill later on.

Having had a bit of a quick look at the screenshots, that app seems to often fall back as many other editors do to giving you lots of flexibility but expecting you to know the tagging to some extent.

My thinking was that the shop overlay is very user-friendly point and shoot style, and enables a load of future new quests which are by design also user-friendly and simple (e.g. seating, opening hours, card, diet etc). This seems to have lots of parallels to adding a post box based on it's location and then getting a load of quick and easy questions about it's collection times and ref etc. It also avoids overwhelming people by making them feel they need to add 20 bits of data rather than just get the object on the map and they or someone else can fill in the finer details.

To avoid making it too broad I'd suggest it only let you add nodes of things where SC asks a quest about the node.

I also possibly somewhat naively assumed that adding such an overlay would mostly just be a case of coming up with the filter now the shop code exists, so it's also a strong benefit for minimal effort.

[mnalis]

I was going to suggest something similar but a bit broader, probably called street furniture or similar, including things like postboxes, benches, fire hydrants, defibrilators

Yeah, if such overlay were to be implemented, I'd also like for it to be generic (so one can add/modify all those features) instead of being specific to one little feature (like fire hydrants only)... But (surprisingly for me) I'm not set on StreetComplete re-implementing every bit of EveryDoor. Especially for such micromapping tasks, I think EveryDoor is actually the better choice, as SC overlays for nodes are inferior to EveryDoor approach (see below for details) - SC overlays for ways really shine, though.

This is a use case that Every Door may be ideal to fill later on.

Having had a bit of a quick look at the screenshots, that app seems to often fall back as many other editors do to giving you lots of flexibility but expecting you to know the tagging to some extent.

Um, not really. It does not expect that you know the tagging. EveryDoor has amenities mode which works akin to StreetComplete Shops overlay, and it has POI mode (which would be akin to this proposed Street furniture overlay). But it works similarly to SC, by using iD presets to show the newbie-friendly human-readable iD name of the feature to user.

Main differences are (click to expand)

- ED _also_ (in addition) shows `key=value` below that `iD` natural-language description (while SC does not, and one has to press `Undo` to see it) - ED shows all the nodes on the map as small circles and color codes them with legend of each color below (while SC overlay shows them as rather big pictograms, and one has to click on the pictogram to get description about what it actually represents). On small screens ED approach wins for me because of much better granularity (unless one is colorblind, of course). That is especially important because of SC max zoom limitations (e.g. https://github.com/streetcomplete/StreetComplete/issues/2878) But otherwise, they are both newbie-friendly in that way. I must say that even if such overlay were implemented, I'd likely still prefer the [EveryDoor](https://every-door.app/) (as it also allows me to add other attributes in simple in quick matter, remembering past settings by default - so after adding `covered` `wooden` `picnic table` with `bench having backrest` is one simple click instead of several quests). Note I do prefer ED to `SC Shops overlay` too, for same reasons. If you haven't tried it, I highly recommend you do. On the other hand, SC Overlays **for the ways** are quite unmatched yet in their combination of power and simplicity, though (although I **do not often need** to use them, as most areas when I use SC are not mapped at all, so SC quests suit me better. I suspect that need might change one most of the quest are initially answered and one needs to do maintenance only).