streetcomplete / StreetComplete

Easy to use OpenStreetMap editor for Android
https://streetcomplete.app
GNU General Public License v3.0
3.84k stars 348 forks source link

Add quest: Accepted Currencies / Payment Methods πŸͺ™πŸ’³ #4396

Closed bohuslav-kovalsky closed 2 years ago

bohuslav-kovalsky commented 2 years ago

General

Affected tag(s) to be modified/added: amenity (maybe with some filter for restaurants, shops, ...) Question asked: What are accepted methods of payment here?

Answer should be some checklist of possible options:

I am not sure if it makes sense to add more of currency tags (https://wiki.openstreetmap.org/w/index.php?title=Key:currency&uselang=en). This would require some local info (what currencies to offer).

Checklist

Checklist for quest suggestions (see guidelines):


Further readings:

matkoniecz commented 2 years ago

Not an overwhelming percentage of quests have the same answer (No spam)

BTC and its variants are extreme rarity. See #4228

Is there any country where say >5% places accept BTC or its variants?

mnalis commented 2 years ago

And for the other values, we already have quests asking whether cash is accepted (only in countries where this is significant chance the answer might be no), and a quest for credit / debit cards acceptance.

Since crypto acceptance in physical shop is still rather rare (unless you can show otherwise for some country?), you can always use Other Answers / Leave a note on one the other quests on that amenity to record this information, so it can be added later (by you or someone else)

Or you an use some other mobile editor like Every Door to record such information when encountered.

bohuslav-kovalsky commented 2 years ago

Hi, thanks for more context. I did not found those older issues, I was searching for bitcoin and not cryptocurrencies. I also did not know there is a cash/card quest.

I really liked the proposal mentioned here

image

☝️ This is basically my proposal.

I propose to consolidate cash and card quest into something like this. Different options can be enabled in different countries.

This would address multiple issues in one quest:

  1. Cash only / cashless
  2. Different cards (Visa / Mastercard / American Express / ...)
  3. ApplePay / AndroidPay
  4. Bitcoin and Lightning Network

Please not, there are countries where Bitcoin acceptance is higher then others. Usually this is happening in hotspots like El Salvadors Bitcoin Beach, Roatan, but also Prague.


Even it is clear that I am bitcoin oriented person, this proposal is not about just Bitcoin, but about payment options in general.

Here where I live (Czechia) is still quite usual that only cash is accepted. But also some places starts to be card-only. Also it is usual that American Express is not accepted. So even quest to consolidate just that would help here.

This would be nice generic solution that will cover many possible options with one quest. This would create very clean and nice UI/UX.

mnalis commented 2 years ago

:point_up: This is basically my proposal.

Yeah, I (as an advanced user) kind of liked that proposal too, but as SC is geared toward novice users, it is not likely to be implemented in this form; see this comment https://github.com/streetcomplete/StreetComplete/issues/3219#issuecomment-922114831

At least not in upstream StreetComplete, maybe in StreetComplete Expert Edition fork, if proposed there...

The problem is that such UI breaks too many quest guidelines, e.g. probably all of those:

Even it is clear that I am bitcoin oriented person, this proposal is not about just Bitcoin, but about payment options in general.

I like bitcoin too, it's just that mapping it via StreetComplete quest is a poor choice for doing it. StreetComplete overlay is not a good match either. I myself would probably stick with EveryDoor to map it as mentioned before (or OsmAnd or Vespucci, but probably EveryDoor).

This would be nice generic solution that will cover many possible options with one quest. This would create very clean and nice UI/UX.

Unfortunately, such UI would be very complex for novice mapper, and hard to answer even for advanced users, as one would have to investigate all accepted payment options before attempting to answer the quest (or, even with tri-state answers yes/no/unknown, someone who does not care about bitcoin would solve the quest for example only for cards and cash, and then the quest would be hidden from everyone (see "πŸ€” No unanswerable quests") - thus rendering quest with such UI basically useless for mapping bitcoin (as there are likely much more people who don't care about it, then those who do, so they'll likely solve such quest before you or I get to them). It has been discussed in that ticket.

mnalis commented 2 years ago

Please not, there are countries where Bitcoin acceptance is higher then others. Usually this is happening in hotspots like El Salvadors Bitcoin Beach, Roatan, but also Prague.

Yes, but StreetComplete is only able to limit quests on a per-country bases. So if in whole of Czechia say 5% of the shops offered payment by bitcoin, adding a simple yes/no quest "Is Bitcoin accepted here?" quest might be created but enabled only in CZ. Like cash quest is only enabled in SE: https://github.com/streetcomplete/StreetComplete/blob/a4d68fecc300b1062b9aaa0b961ebe847af9f598/app/src/main/java/de/westnordost/streetcomplete/quests/accepts_cash/AddAcceptsCash.kt#L56

Duplicate of #4228

bohuslav-kovalsky commented 2 years ago

Thanks for info about StreetComplete Expert Edition. This looks like a good addition to the toolset.

bohuslav-kovalsky commented 2 years ago

@mnalis Also you mentioned that quest is hidden from everyone.

Is there some timeout after which quest reappears for update? I noticed quests like "Are opening hours this still correct?" Does this apply to all quests or only to some?

Is there a place where to read about how this behaves?

Thanks!

mnalis commented 2 years ago

@mnalis Also you mentioned that quest is hidden from everyone.

Yes, that is by design. Once a quest is solved by one user, it must not appear to other users, e.g. this quest guideline:

Is there some timeout after which quest reappears for update? I noticed quests like "Are opening hours this still correct?" Does this apply to all quests or only to some?

Yes, some (but not all) quests do ask for resurvey after some time. You can check each quest if it contains lines like this:

https://github.com/streetcomplete/StreetComplete/blob/a4d68fecc300b1062b9aaa0b961ebe847af9f598/app/src/main/java/de/westnordost/streetcomplete/quests/smoking/AddSmoking.kt#L39

That means that this quest will be asked if:

The interval of quest reappearance (and whether resurvey will happen at all) is basically decided by quest author guessing how often some feature is likely to change.

Not that resurvey would help much in this particular case: if the odds were heavily against you (or someone else interested in BTC) that you'd be the first one to solve that quest initially, they would still be heavily against you that you'd be the first one to resurvey it. Sure, you'd get some chance every x years, but if that chance is small it is far more likely that you'd die from old age (or bitcoin becomes extinct/replaced by something better) before you hit that jackpot...

Is there a place where to read about how this behaves?

There is CONTRIBUTING_A_NEW_QUEST.md which gives direction how to create new quest; it should thus also give an idea how most simpler quests are done too.